| Message ID | 20221222000625.220692-9-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | 9736b971b519b725507116578d780d822755b2a6 |
| Headers | show |
| Series | AF_XDP build fixes and enhancements. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On 22 Dec 2022, at 1:06, Ilya Maximets wrote: > All supported versions of Fedora do package libxdp and libbpf, so it > makes sense to enable AF_XDP support. > > Control files for debian packaging are much less flexible, so its hard > to enable AF_XDP builds while not breaking builds for version of Ubuntu > and Debian that do not package libbpf or libxdp. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- Changes looks good to me, but we need a fix for patch 7. Acked-by: Eelco Chaudron <echaudro@redhat.com>
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 3091e204e..44899c1ca 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel/openvswitch-fedora.spec.in @@ -26,8 +26,8 @@ %bcond_without libcapng # To enable DPDK support, specify '--with dpdk' when building %bcond_with dpdk -# To enable AF_XDP support, specify '--with afxdp' when building -%bcond_with afxdp +# To disable AF_XDP support, specify '--without afxdp' when building +%bcond_without afxdp # If there is a need to automatically enable the package after installation, # specify the "--with autoenable"
All supported versions of Fedora do package libxdp and libbpf, so it makes sense to enable AF_XDP support. Control files for debian packaging are much less flexible, so its hard to enable AF_XDP builds while not breaking builds for version of Ubuntu and Debian that do not package libbpf or libxdp. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- rhel/openvswitch-fedora.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)