From patchwork Wed Nov 16 10:47:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Britstein X-Patchwork-Id: 1704468 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=aswmE2p+; dkim-atps=neutral Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NC0BW5ghrz23n4 for ; Wed, 16 Nov 2022 21:48:03 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CD75D41796; Wed, 16 Nov 2022 10:48:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CD75D41796 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=aswmE2p+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yyVJeLuT23yi; Wed, 16 Nov 2022 10:47:59 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 864A441821; Wed, 16 Nov 2022 10:47:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 864A441821 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2F154C0071; Wed, 16 Nov 2022 10:47:58 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E6FEFC002D for ; Wed, 16 Nov 2022 10:47:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C117661012 for ; Wed, 16 Nov 2022 10:47:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C117661012 Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=aswmE2p+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wu7DVpt9thMB for ; Wed, 16 Nov 2022 10:47:55 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B56DB6100F Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2062b.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8b::62b]) by smtp3.osuosl.org (Postfix) with ESMTPS id B56DB6100F for ; Wed, 16 Nov 2022 10:47:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9QdZwBNRdxS+Y23WvbI+WJuj/gOe+KTdCcx2H/FsCLCEbpjGYdf8UFwMPyrPHEKCzQx+i7dqgD2LpO7b0YoaGF8Bk2uvcBfEH7yFlDQmd3yg3o7Pq4N2/fhqTaXWVB5FrDi2ivGVwNxyY7VMEaz7DSFo9lCH2gTjqqv6qFhkWIS2n54vn8uUZ+/p9UdRQ1tJhAh9f5QAc5hZlMXj/YUzPU/WC+U8V8HgiYrKqvLsGwnbMbAxrzif4xFFtoCoI0BuGIS9k2bCIfX7XNuDTi07v0kcxJzBR7tuoBuKpNBRRXyXW4in/QzdM/updn0mj1mTEp8XczVoksIBP579hp7sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FGcRraTZ5bbZgigYBOvXlYoAOq/YxSaZv4puB74bceE=; b=PIuvZSG7mZ7C37nhAii+UuAVVnzTfIvuElvGffDcmFn5PWwyj8NKxFQ+a0DlMIrpILPI/MoTUNqEO2lkVxvo9mInHhUadPXLOsfO5wpjSj/9l3WNMzWB5KX9q67cxyRO4ALzTbgmvtlBQvS+kWG7DoMfsBoEyF+3IsMCvjkPDzAHMDBm0SJqq3BqAYEI9R8oMcHXEtwJvvyKwogULLf65tYmB+BnFSFCANXsAdmKS2jodIbkLOFV/KZP0uAsbbY1lMsvadfys6XvabPXJEFudVapXR2NRE55v5BNFE5sj6I9pRHqzoXHSnIhDavrZxgJ+XRs76Y15KasTMvkhDhPvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FGcRraTZ5bbZgigYBOvXlYoAOq/YxSaZv4puB74bceE=; b=aswmE2p+ZE31SmSXa4XW1ywrJdFDFZprbPXW508h70GX4hrVgBLwQLvInF9x9N0ECrEFVbSfVEh+FTMkcHh1qNJRsfTIuZW3ecLVgFKJIijswtAeI7ToMkzABnhX3Uf5xaeSKMwx1Hey2cNKvG8Srbw9gTZT6V1UIthax6vQEaoYr3HKywEl062DtOgFdRY6eW3EzJVDt4QnHZ678M/fvge4Ze43TsU6geWMviqu3+xcM1jqpTzKO6dD5PykwMKENrFHMbtKSr6GQVsRA3kLel1k+SO+LTY/5/XgJRTK9vlYNwmlf53bUqQXY2WN1aJAuQ49UcIDqizxdMlSkufzXQ== Received: from DM6PR18CA0013.namprd18.prod.outlook.com (2603:10b6:5:15b::26) by DM6PR12MB4532.namprd12.prod.outlook.com (2603:10b6:5:2af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 10:47:53 +0000 Received: from DM6NAM11FT104.eop-nam11.prod.protection.outlook.com (2603:10b6:5:15b:cafe::4b) by DM6PR18CA0013.outlook.office365.com (2603:10b6:5:15b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.15 via Frontend Transport; Wed, 16 Nov 2022 10:47:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT104.mail.protection.outlook.com (10.13.173.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Wed, 16 Nov 2022 10:47:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:45 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 16 Nov 2022 02:47:43 -0800 To: , Simon Horman , "Ilya Maximets" Date: Wed, 16 Nov 2022 12:47:20 +0200 Message-ID: <20221116104727.915151-2-elibr@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221116104727.915151-1-elibr@nvidia.com> References: <20221116104727.915151-1-elibr@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT104:EE_|DM6PR12MB4532:EE_ X-MS-Office365-Filtering-Correlation-Id: 0094839c-ea97-40ff-c74a-08dac7c003a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nWTw14sqFctW6GPlUXyUJ9QYAMZAKC/DCWXNZq8muRU6Tq2Ie06I9In/a29irDyEF7EfDNT70n+dRlboXFSvmofFHbjFknQYRAUdWEmUtrSqDPiy16R0nTVVqbLbBFHSvb6sMaDYwYiqAvHlsHt10ARbWUjxBBLQQKACLFVRCg8VcRJakJeO4XYGAPtg5+hApwqMlt/c0OgmoNtxB1nZbPz9p3L/7afSb4oPkN2EGnyJ6E9HqhXxomPVKpr/l9gn0TjX8zfgsea6DwXD38i/kcgHe+q17iUoN6v+S0OoRE0/mTQlcS5Cxx2SOWI/jXninnFVpw/DqraUzoe/UqtNiklFT0ATBMKEZEgivIR2h9nbRjf4sCCa/LlAq8aqRas0QoIf8QicE/7gikufwo+xnwdpbUys3T0eJA/LE4BPPOo+4WUp8fOcjYWKezGSIb3iirtF9VYS11Y8iQXR23EjZFlJePkg67WAhDCzLnQzh94BaIWOwWWK3NsgdF1SasupebqpI4jaBs/RkGgQm/GaGPiUwxYBgbDqTz6IZXptnYDGmkzcvNU/QAhnf4hqj9+WDD1pijbMmVay4BlaPZfl0aJ1hTemzslLOTvORuP+6sU2GynfS61B4Rg3/FzOwRIqwWDcYb4OSRESUhIisTSRB4yg4pdXWiM+QqnYbq0HJxd1daf76YjBD+7GKt9MZtxg5mhFDtSj7cR+zfC8vxsw3pHPFL1U//dTPJ5w7ivP9l5znFUx0r+tTU1IphOSFHny98b3ObKSujj3aV78PUkwnQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(36840700001)(40470700004)(46966006)(7696005)(6666004)(478600001)(426003)(40480700001)(2906002)(6286002)(26005)(107886003)(16526019)(336012)(8676002)(186003)(47076005)(70586007)(4326008)(70206006)(5660300002)(40460700003)(356005)(36756003)(110136005)(82310400005)(316002)(54906003)(8936002)(41300700001)(86362001)(55016003)(36860700001)(7636003)(2616005)(1076003)(83380400001)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 10:47:53.3694 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0094839c-ea97-40ff-c74a-08dac7c003a6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT104.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4532 Cc: Eli Britstein Subject: [ovs-dev] [PATCH V2 1/8] dp-packet: Fix dp-packet may be used initialized X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Eli Britstein via dev From: Eli Britstein Reply-To: Eli Britstein Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" With --enable-Werror and --with-dpdk=no: In function 'dp_packet_reset_offload', inlined from 'dp_packet_init__' at ../lib/dp-packet.c:35:5, inlined from 'dp_packet_use__' at ../lib/dp-packet.c:50:5, inlined from 'dp_packet_use' at ../lib/dp-packet.c:60:5, inlined from 'dp_packet_init' at ../lib/dp-packet.c:126:5, inlined from 'dp_packet_new' at ../lib/dp-packet.c:154:5: ../lib/dp-packet.h:944:32: error: 'MEM[(uint32_t *)p_14 + 16B]' may be used uninitialized [-Werror=maybe-uninitialized] 944 | *dp_packet_ol_flags_ptr(p) &= ~DP_PACKET_OL_SUPPORTED_MASK; | ^ Fixes: a47e2db209e4 ("dp-packet: Refactor offloading API.") Signed-off-by: Eli Britstein --- lib/dp-packet.c | 1 - lib/dp-packet.h | 7 ++++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 4538d2a61..f654752a1 100644 --- a/lib/dp-packet.c +++ b/lib/dp-packet.c @@ -32,7 +32,6 @@ dp_packet_init__(struct dp_packet *b, size_t allocated, enum dp_packet_source so dp_packet_reset_offsets(b); pkt_metadata_init(&b->md, 0); dp_packet_reset_cutlen(b); - dp_packet_reset_offload(b); /* Initialize implementation-specific fields of dp_packet. */ dp_packet_init_specific(b); /* By default assume the packet type to be Ethernet. */ diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 55eeaab2c..9864dfcbf 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -572,7 +572,8 @@ dp_packet_init_specific(struct dp_packet *p) { /* This initialization is needed for packets that do not come from DPDK * interfaces, when vswitchd is built with --with-dpdk. */ - p->mbuf.ol_flags = p->mbuf.tx_offload = p->mbuf.packet_type = 0; + *dp_packet_ol_flags_ptr(p) = 0; + p->mbuf.tx_offload = p->mbuf.packet_type = 0; p->mbuf.nb_segs = 1; p->mbuf.next = NULL; } @@ -638,9 +639,9 @@ dp_packet_set_allocated(struct dp_packet *b, uint16_t s) #else /* DPDK_NETDEV */ static inline void -dp_packet_init_specific(struct dp_packet *p OVS_UNUSED) +dp_packet_init_specific(struct dp_packet *p) { - /* There are no implementation-specific fields for initialization. */ + *dp_packet_ol_flags_ptr(p) = 0; } static inline void *