| Message ID | 20221113144623.698843-1-elibr@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev] debian, rhel: Enable Werror option in spec files | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/intel-ovs-compilation | fail | test: fail |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
On Sun, Nov 13, 2022 at 04:46:23PM +0200, Eli Britstein wrote: > Following resolving DPDK cast align warnings as stated in [1], enforce > -Werror for RPM builds too. > > [1] 0b6d2faace76 ("ci: Remove -Wno-cast-align from CI.") > > Signed-off-by: Eli Britstein <elibr@nvidia.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> I'll let this sit a little longer for review to accumulate before applying.
>-----Original Message----- >From: Simon Horman <simon.horman@corigine.com> >Sent: Monday, 14 November 2022 12:44 >To: Eli Britstein <elibr@nvidia.com> >Cc: dev@openvswitch.org; Ilya Maximets <i.maximets@ovn.org>; Simon >Horman <simon.horman@netronome.com>; Salem Sol <salems@nvidia.com> >Subject: Re: [PATCH] debian, rhel: Enable Werror option in spec files > >External email: Use caution opening links or attachments > > >On Sun, Nov 13, 2022 at 04:46:23PM +0200, Eli Britstein wrote: >> Following resolving DPDK cast align warnings as stated in [1], enforce >> -Werror for RPM builds too. >> >> [1] 0b6d2faace76 ("ci: Remove -Wno-cast-align from CI.") >> >> Signed-off-by: Eli Britstein <elibr@nvidia.com> > >Reviewed-by: Simon Horman <simon.horman@corigine.com> > >I'll let this sit a little longer for review to accumulate before applying. Actually, I see CI fails with it, as there are some warnings that are now discovered. We need to fix them first.
On Mon, Nov 14, 2022 at 10:46:40AM +0000, Eli Britstein wrote: > > > >-----Original Message----- > >From: Simon Horman <simon.horman@corigine.com> > >Sent: Monday, 14 November 2022 12:44 > >To: Eli Britstein <elibr@nvidia.com> > >Cc: dev@openvswitch.org; Ilya Maximets <i.maximets@ovn.org>; Simon > >Horman <simon.horman@netronome.com>; Salem Sol <salems@nvidia.com> > >Subject: Re: [PATCH] debian, rhel: Enable Werror option in spec files > > > >External email: Use caution opening links or attachments > > > > > >On Sun, Nov 13, 2022 at 04:46:23PM +0200, Eli Britstein wrote: > >> Following resolving DPDK cast align warnings as stated in [1], enforce > >> -Werror for RPM builds too. > >> > >> [1] 0b6d2faace76 ("ci: Remove -Wno-cast-align from CI.") > >> > >> Signed-off-by: Eli Britstein <elibr@nvidia.com> > > > >Reviewed-by: Simon Horman <simon.horman@corigine.com> > > > >I'll let this sit a little longer for review to accumulate before applying. > Actually, I see CI fails with it, as there are some warnings that are now discovered. We need to fix them first. Ok, lets drop this for now.
diff --git a/debian/rules b/debian/rules index 971bc1775..ffc218e9d 100755 --- a/debian/rules +++ b/debian/rules @@ -24,7 +24,7 @@ override_dh_auto_configure: cd _debian && ( \ test -e Makefile || \ ../configure --prefix=/usr --localstatedir=/var --enable-ssl \ - --sysconfdir=/etc \ + --sysconfdir=/etc --enable-Werror \ $(DATAPATH_CONFIGURE_OPTS) \ $(EXTRA_CONFIGURE_OPTS) \ ) @@ -34,7 +34,7 @@ ifeq (,$(filter nodpdk, $(DEB_BUILD_OPTIONS))) cd _dpdk && ( \ test -e Makefile || \ ../configure --prefix=/usr --localstatedir=/var --enable-ssl \ - --with-dpdk=shared --sysconfdir=/etc \ + --with-dpdk=shared --sysconfdir=/etc --enable-Werror \ $(DATAPATH_CONFIGURE_OPTS) \ $(EXTRA_CONFIGURE_OPTS) \ ) diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in index 9903dd10a..35ae42356 100644 --- a/rhel/openvswitch.spec.in +++ b/rhel/openvswitch.spec.in @@ -70,7 +70,7 @@ Tailored Open vSwitch SELinux policy %build ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=%{_localstatedir} \ - --libdir=%{_libdir} --enable-ssl --enable-shared + --libdir=%{_libdir} --enable-ssl --enable-shared --enable-Werror make %{_smp_mflags} make selinux-policy
Following resolving DPDK cast align warnings as stated in [1], enforce -Werror for RPM builds too. [1] 0b6d2faace76 ("ci: Remove -Wno-cast-align from CI.") Signed-off-by: Eli Britstein <elibr@nvidia.com> --- debian/rules | 4 ++-- rhel/openvswitch.spec.in | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)