@@ -97,9 +97,10 @@ odp_execute_action_set(const char *name)
for (int i = 0; i < ACTION_IMPL_MAX; i++) {
/* String compare, and set ptrs atomically. */
if (!strcmp(action_impls[i].name, name)) {
- active_action_impl_index = i;
-
- VLOG_INFO("Action implementation set to %s", name);
+ if (i != active_action_impl_index) {
+ active_action_impl_index = i;
+ VLOG_INFO("Action implementation set to %s", name);
+ }
return &action_impls[i];
}
}
@@ -142,8 +143,8 @@ odp_execute_action_init(void)
action_impls[i].available = avail;
- VLOG_INFO("Action implementation %s (available: %s)",
- action_impls[i].name, avail ? "Yes" : "No");
+ VLOG_DBG("Actions implementation '%s' %s available.",
+ action_impls[i].name, avail ? "is" : "is not");
/* The following is a run-time check to make sure a scalar
* implementation exists for the given ISA implementation. This is to
@@ -182,7 +182,6 @@ m4_define([_OVS_VSWITCHD_START],
on_exit "kill_ovs_vswitchd `cat ovs-vswitchd.pid`"
AT_CHECK([[sed < stderr '
/ovs_numa|INFO|Discovered /d
-/odp_execute_impl|INFO|Action implementation /d
/vlog|INFO|opened log file/d
/vswitchd|INFO|ovs-vswitchd (Open vSwitch)/d
/reconnect|INFO|/d
There is no need to log if the implementation didn't change. Scalar one is default, any change will be logged. And availability is not really important to log at INFO level. Moving these logs to DBG level to avoid littering the log file and confusing users. We do the same for miniflow_extract and datapath interface implementations. Additionally, text of the log message made more readable and uniform with the one used for miniflow_extract. Fixes: 95e4a35b0a1d ("odp-execute: Add function pointers to odp-execute for different action implementations.") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- lib/odp-execute-private.c | 11 ++++++----- tests/ofproto-macros.at | 1 - 2 files changed, 6 insertions(+), 6 deletions(-)