| Message ID | 20220608024653.3118045-2-twilson@redhat.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [ovs-dev,v4,1/2] Handle re-used pids in pidfile_is_running | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/intel-ovs-compilation | fail | test: fail |
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl index 14d37a3d6..e2f05915b 100755 --- a/utilities/ovn-ctl +++ b/utilities/ovn-ctl @@ -200,7 +200,7 @@ start_ovsdb__() { ovn_install_dir "$ovn_etcdir" # Check and eventually start ovsdb-server for DB - if pidfile_is_running $db_pid_file; then + if pidfile_is_running $db_pid_file ovsdb-server; then return fi
When checking if ovsdb-server is running, ensure that the binary we are going to run matches the one actually running with the the pid that was in our pidfile. Signed-off-by: Terry Wilson <twilson@redhat.com> --- utilities/ovn-ctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)