From patchwork Tue May 17 17:35:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kumar Amber X-Patchwork-Id: 1632486 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=de9LAK0e; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L2kKq0YdZz9s0w for ; Wed, 18 May 2022 03:55:11 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CAB5B419A2; Tue, 17 May 2022 17:55:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZXPxphQmYeqq; Tue, 17 May 2022 17:55:07 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id A6EBB41761; Tue, 17 May 2022 17:55:06 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 750D1C0032; Tue, 17 May 2022 17:55:06 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 06057C002D for ; Tue, 17 May 2022 17:55:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EFE0060A84 for ; Tue, 17 May 2022 17:55:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gz7iLIwtJuf8 for ; Tue, 17 May 2022 17:55:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by smtp3.osuosl.org (Postfix) with ESMTPS id B40D460812 for ; Tue, 17 May 2022 17:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652810103; x=1684346103; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=acqkl4f7DbSg0mxwXcUETsGNMB11UPaQO7UZNnKaiok=; b=de9LAK0ezZ2Anr1O22VpcnPeT5x6PcmM5fwCiMtmp9MOixqFVk5kHunA 9L4P6WF/4ujj9QMwuhLEq+NfRMWFfJ4ogGzQi6VNAYsMeaHB+tYfsEQDd viUnEnuj5xT3XKa5PNoiRY4Zj0raWxqlaZwk2nGqgL/XrZJ7BWp1EBDNu BKa9hl+bCZRSDeMrnmSf9G445u0mO657LEaR/d99xWLrkjYILXhiaR0x3 HkBwLq0HzqFL1ILkAIvA1gBCFTOrEYLHylrgyQdlsAX/Wro1Uq5QNHa6R jXzxwcUYfRNjeuHxekkDsIUrcJkQqyLm/uynbUqJeD8k0mT152CvIGPcj A==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="331885395" X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="331885395" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 10:55:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="555894433" Received: from ubuntu.iind.intel.com (HELO localhost.localdomain) ([10.190.213.111]) by orsmga002.jf.intel.com with ESMTP; 17 May 2022 10:55:00 -0700 From: Kumar Amber To: ovs-dev@openvswitch.org Date: Tue, 17 May 2022 23:05:23 +0530 Message-Id: <20220517173523.588912-1-kumar.amber@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Cc: i.maximets@ovn.org, Kumar Amber Subject: [ovs-dev] [PATCH v1] Pmd.at: fix dpcls and dpif configuration test cases. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Without running set command first the string matching fails on get command beacuse DPCLS prio value is different for different default builds like with --enable-autovalidator build auto-validator prio is set to 255 and if the build is a scalar than generic value is default 255. The same problem is seen with dpif where re-arranging the get command after set makes it consistent across any builds. Fixes: cc0a87b11c (pmd.at: Add test-cases for DPCLS and DPIF commands.) Signed-off-by: Kumar Amber Acked-by: Michael Phelan --- tests/pmd.at | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/tests/pmd.at b/tests/pmd.at index 0a451f33c..3962dd2bd 100644 --- a/tests/pmd.at +++ b/tests/pmd.at @@ -1113,15 +1113,15 @@ AT_SETUP([PMD - dpif configuration]) OVS_VSWITCHD_START([], [], [], [--dummy-numa 0,0]) AT_CHECK([ovs-vsctl add-port br0 p1 -- set Interface p1 type=dummy-pmd]) +AT_CHECK([ovs-appctl dpif-netdev/dpif-impl-set dpif_scalar], [0], [dnl +DPIF implementation set to dpif_scalar. +]) + AT_CHECK([ovs-vsctl show], [], [stdout]) AT_CHECK([ovs-appctl dpif-netdev/dpif-impl-get | grep "dpif_scalar"], [], [dnl dpif_scalar (pmds: 0) ]) -AT_CHECK([ovs-appctl dpif-netdev/dpif-impl-set dpif_scalar], [0], [dnl -DPIF implementation set to dpif_scalar. -]) - OVS_VSWITCHD_STOP AT_CLEANUP @@ -1130,13 +1130,6 @@ OVS_VSWITCHD_START([], [], [], [--dummy-numa 0,0]) AT_CHECK([ovs-vsctl add-port br0 p1 -- set Interface p1 type=dummy-pmd]) AT_CHECK([ovs-vsctl show], [], [stdout]) -AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep generic], [], [dnl - 1 : generic -]) - -AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-get | grep autovalidator], [], [dnl - 0 : autovalidator -]) AT_CHECK([ovs-appctl dpif-netdev/subtable-lookup-prio-set autovalidator 3], [0], [dnl Lookup priority change affected 0 dpcls ports and 0 subtables.