diff mbox series

[ovs-dev,v5,3/5] dpif-netdev-extract: Remove unnecessary compiler targets.

Message ID 20220517100818.15639-4-cian.ferriter@intel.com
State Accepted
Commit 34a77ca704df8defcb7a7b04c9b6319331474f56
Headers show
Series Build some AVX512 code on older compilers. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Ferriter, Cian May 17, 2022, 10:08 a.m. UTC 
No instructions from the AVX512VL ISA are used.

Compilation for AVX512F and AVX512 BW ISA are already enabled in
lib/automake.mk for the dpif-netdev-lookup-avx512-gather.c file because
it's part of the libopenvswitchavx512.la library. They don't need to be
enabled at a function level.

Remove these unnecessary function-level compiler target attributes.

Signed-off-by: Cian Ferriter <cian.ferriter@intel.com>
Acked-by: Sunil Pai G <sunil.pai.g@intel.com>

---
v5:
* Remove an 'avx512bw' target since it's also unnecessary as per Sunil's
  suggestion.
* Add Sunil's Acked-by tag.

v4:
* Remove the 'avx512f' target since it's also unnecessary.
* Sunil acked the v3 version of this commit, but since it's changed, I'm
  not carrying the ack over.
---
 lib/dpif-netdev-extract-avx512.c | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/lib/dpif-netdev-extract-avx512.c b/lib/dpif-netdev-extract-avx512.c
index 6b6fe07db..4a94dfcfd 100644
--- a/lib/dpif-netdev-extract-avx512.c
+++ b/lib/dpif-netdev-extract-avx512.c
@@ -52,7 +52,6 @@ 
 
 /* AVX512-BW level permutex2var_epi8 emulation. */
 static inline __m512i
-__attribute__((target("avx512bw")))
 _mm512_maskz_permutex2var_epi8_skx(__mmask64 k_mask,
                                    __m512i v_data_0,
                                    __m512i v_shuf_idxs,
@@ -632,8 +631,6 @@  mfex_avx512_process(struct dp_packet_batch *packets,
 
 #define DECLARE_MFEX_FUNC(name, profile)                                \
 uint32_t                                                                \
-__attribute__((__target__("avx512f")))                                  \
-__attribute__((__target__("avx512vl")))                                 \
 __attribute__((__target__("avx512vbmi")))                               \
 mfex_avx512_vbmi_##name(struct dp_packet_batch *packets,                \
                         struct netdev_flow_key *keys, uint32_t keys_size,\
@@ -645,8 +642,6 @@  mfex_avx512_vbmi_##name(struct dp_packet_batch *packets,                \
 }                                                                       \
                                                                         \
 uint32_t                                                                \
-__attribute__((__target__("avx512f")))                                  \
-__attribute__((__target__("avx512vl")))                                 \
 mfex_avx512_##name(struct dp_packet_batch *packets,                     \
                    struct netdev_flow_key *keys, uint32_t keys_size,    \
                    odp_port_t in_port, struct dp_netdev_pmd_thread      \