| Message ID | 202205091721177591758@chinatelecom.cn |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev,v2] ovs-ofctl: '--bundle' option can be used with OpenFlow 1.3 | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Mon, May 9, 2022 at 5:21 AM yangchang <yangchang@chinatelecom.cn> wrote: > > From the commit 25070e045e, bundle option has be used with OpenFlow 1.3 Nit, s/has/can/ But the content of the patch looks correct. Acked-by: Mike Pattrick <mkp@redhat.com> Cheers, M > > Signed-off-by: yangchang <yangchang@chinatelecom.cn> > --- > utilities/ovs-ofctl.8.in | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in > index e903ca1..35f4dea 100644 > --- a/utilities/ovs-ofctl.8.in > +++ b/utilities/ovs-ofctl.8.in > @@ -1312,7 +1312,7 @@ well as cookie values and table IDs if they are zero. > Do not execute read/write commands. > . > .IP "\fB\-\-bundle\fR" > -Execute flow mods as an OpenFlow 1.4 atomic bundle transaction. > +Execute flow mods as an OpenFlow 1.3 atomic bundle transaction. > .RS > .IP \(bu > Within a bundle, all flow mods are processed in the order they appear > @@ -1324,15 +1324,15 @@ the transaction, or after all the flow mods in the bundle have been > successfully applied. > .IP \(bu > The beginning and the end of the flow table modification commands in a > -bundle are delimited with OpenFlow 1.4 bundle control messages, which > +bundle are delimited with OpenFlow 1.3 bundle control messages, which > makes it possible to stream the included commands without explicit > OpenFlow barriers, which are otherwise used after each flow table > modification command. This may make large modifications execute > faster as a bundle. > .IP \(bu > -Bundles require OpenFlow 1.4 or higher. An explicit \fB-O > -OpenFlow14\fR option is not needed, but you may need to enable > -OpenFlow 1.4 support for OVS by setting the OVSDB \fIprotocols\fR > +Bundles require OpenFlow 1.3 or higher. An explicit \fB-O > +OpenFlow13\fR option is not needed, but you may need to enable > +OpenFlow 1.3 support for OVS by setting the OVSDB \fIprotocols\fR > column in the \fIbridge\fR table. > .RE > . > -- > 1.8.3.1 > > > > yangchang@chinatelecom.cn > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index e903ca1..35f4dea 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@ -1312,7 +1312,7 @@ well as cookie values and table IDs if they are zero. Do not execute read/write commands. . .IP "\fB\-\-bundle\fR" -Execute flow mods as an OpenFlow 1.4 atomic bundle transaction. +Execute flow mods as an OpenFlow 1.3 atomic bundle transaction. .RS .IP \(bu Within a bundle, all flow mods are processed in the order they appear @@ -1324,15 +1324,15 @@ the transaction, or after all the flow mods in the bundle have been successfully applied. .IP \(bu The beginning and the end of the flow table modification commands in a -bundle are delimited with OpenFlow 1.4 bundle control messages, which +bundle are delimited with OpenFlow 1.3 bundle control messages, which makes it possible to stream the included commands without explicit OpenFlow barriers, which are otherwise used after each flow table modification command. This may make large modifications execute faster as a bundle. .IP \(bu -Bundles require OpenFlow 1.4 or higher. An explicit \fB-O -OpenFlow14\fR option is not needed, but you may need to enable -OpenFlow 1.4 support for OVS by setting the OVSDB \fIprotocols\fR +Bundles require OpenFlow 1.3 or higher. An explicit \fB-O +OpenFlow13\fR option is not needed, but you may need to enable +OpenFlow 1.3 support for OVS by setting the OVSDB \fIprotocols\fR column in the \fIbridge\fR table. .RE .
From the commit 25070e045e, bundle option has be used with OpenFlow 1.3 Signed-off-by: yangchang <yangchang@chinatelecom.cn> --- utilities/ovs-ofctl.8.in | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 1.8.3.1 yangchang@chinatelecom.cn