| Message ID | 20220310044115.162536-1-hepeng.0320@bytedance.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev,ovs-dev,v2] dpif-netdev: change execute->flow->in_port into odp_port | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/intel-ovs-compilation | success | test: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He <xnhp0320@gmail.com> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Peng He <hepeng.0320@bytedance.com>, Aaron Conole <aconole@redhat.com> Lines checked: 44, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On Thu, Mar 10, 2022 at 04:41:15AM +0000, Peng He wrote: > the flow->in_port value is previously ignored. We normally use > the the md->in_port of the first packet in the batch to get the > value. However, since some actions might need to be redo due to > the fix of ipf issues, we might have an empty batch to feed the > action execute, so the conntrack makes use of flow->in_port > to get the in_port value and form the ipf_ctx. > > This patch changes execute->flow->in_port into odp_port before > doing action executes. with this patch, the ipf_ctx patch will > not cause testsuite report errors. > > Signed-off-by: Peng He <hepeng.0320@bytedance.com> > Acked-by: Mike Pattrick <mkp@redhat.com> > Signed-off-by: Aaron Conole <aconole@redhat.com> > > v1->v2: change in_port in dpif layer rather than ofproto-dpif layer Hi, I noticed this stale patch in patchwork. It does still apply. But does not seem to have got any attention. Moreover the patch robot flagged a problem with the sign-off from Peng He. If it is still relevant please consider (rebasing?) and reposting. I am marking this as changes requested in patchwork.
If ipf ctx is needed this one is needed too, if not, you can drop the patch Simon Horman <simon.horman@corigine.com>于2023年6月8日 周四22:16写道： > On Thu, Mar 10, 2022 at 04:41:15AM +0000, Peng He wrote: > > the flow->in_port value is previously ignored. We normally use > > the the md->in_port of the first packet in the batch to get the > > value. However, since some actions might need to be redo due to > > the fix of ipf issues, we might have an empty batch to feed the > > action execute, so the conntrack makes use of flow->in_port > > to get the in_port value and form the ipf_ctx. > > > > This patch changes execute->flow->in_port into odp_port before > > doing action executes. with this patch, the ipf_ctx patch will > > not cause testsuite report errors. > > > > Signed-off-by: Peng He <hepeng.0320@bytedance.com> > > Acked-by: Mike Pattrick <mkp@redhat.com> > > Signed-off-by: Aaron Conole <aconole@redhat.com> > > > > v1->v2: change in_port in dpif layer rather than ofproto-dpif layer > > Hi, > > I noticed this stale patch in patchwork. > > It does still apply. But does not seem to have got any attention. > Moreover the patch robot flagged a problem with the sign-off from Peng He. > > If it is still relevant please consider (rebasing?) and reposting. > I am marking this as changes requested in patchwork. >
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 9f35713ef..fb1264c14 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4566,6 +4566,9 @@ dpif_netdev_execute(struct dpif *dpif, struct dpif_execute *execute) /* Making a copy because the packet might be stolen during the execution * and caller might still need it. */ struct dp_packet *packet_clone = dp_packet_clone(execute->packet); + /* change execute->flow->in_port into odp_port */ + *CONST_CAST(union flow_in_port *, &execute->flow->in_port) + = packet_clone->md.in_port; dp_packet_batch_init_packet(&pp, packet_clone); dp_netdev_execute_actions(pmd, &pp, false, execute->flow, execute->actions, execute->actions_len);