| Message ID | 20220225153806.21662-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Commit | b1e783dde42dc589d416753ae3d6c8585b7fb7da |
| Headers | show |
| Series | [ovs-dev] tests: Ignore log about failing to set NETLINK_EXT_ACK. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/intel-ovs-compilation | success | test: success |
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 25 Feb 2022, at 16:38, Dumitru Ceara wrote: > Since 4a6a4734622e ("netlink-socket: Log extack error messages in > netlink transactions."), tests fail on older systems that don't support > NETLINK_EXT_ACK. It's not really an issue, so we can just ignore the > log. > > CC: Paolo Valerio <pvalerio@redhat.com> > CC: Eelco Chaudron <echaudro@redhat.com> > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- Changes look good, only tested on a kernel with NETLINK_EXT_ACK :( Acked-by: Eelco Chaudron <echaudro@redhat.com>
Hello Dumitru, Dumitru Ceara <dceara@redhat.com> writes: > Since 4a6a4734622e ("netlink-socket: Log extack error messages in > netlink transactions."), tests fail on older systems that don't support > NETLINK_EXT_ACK. It's not really an issue, so we can just ignore the > log. > > CC: Paolo Valerio <pvalerio@redhat.com> > CC: Eelco Chaudron <echaudro@redhat.com> > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- thanks for taking care of this. I tested it successfully against kernel 4.9, and the patch LGTM. Acked-by: Paolo Valerio <pvalerio@redhat.com>
On 2/25/22 16:38, Dumitru Ceara wrote: > Since 4a6a4734622e ("netlink-socket: Log extack error messages in > netlink transactions."), tests fail on older systems that don't support > NETLINK_EXT_ACK. It's not really an issue, so we can just ignore the > log. > > CC: Paolo Valerio <pvalerio@redhat.com> > CC: Eelco Chaudron <echaudro@redhat.com> > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- Thanks! Applied to master and 2.17. Best regards, Ilya Maximets.
diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 736d9809cb32..7051d95396ff 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -175,6 +175,7 @@ m4_define([_OVS_VSWITCHD_START], /dpdk|INFO|DPDK Disabled - Use other_config:dpdk-init to enable/d /netlink_socket|INFO|netlink: could not enable listening to all nsid/d /probe tc:/d +/setting extended ack support failed/d /tc: Using policy/d']]) ]) @@ -239,6 +240,7 @@ check_logs () { /timeval.*context switches: [[0-9]]* voluntary, [[0-9]]* involuntary/d /ovs_rcu.*blocked [[0-9]]* ms waiting for .* to quiesce/d /Dropped [[0-9]]* log messages/d +/setting extended ack support failed/d /|WARN|/p /|ERR|/p /|EMER|/p" ${logs} diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at index bba4fea2bce9..977b2eba1f26 100644 --- a/tests/ovs-vswitchd.at +++ b/tests/ovs-vswitchd.at @@ -121,6 +121,7 @@ OVS_APP_EXIT_AND_WAIT_BY_TARGET(["`pwd`"/unixctl2], [ovs-vswitchd-2.pid]) # the process. AT_CHECK([sed -n " /|ERR|another ovs-vswitchd process is running/d +/setting extended ack support failed/d /|WARN|/p /|ERR|/p /|EMER|/p" fakelog @@ -148,6 +149,7 @@ AT_CHECK([grep "wakeup due to" ovs-vswitchd.log], [ignore]) # check the log, should not see any WARN/ERR/EMER log. AT_CHECK([sed -n " +/setting extended ack support failed/d /|WARN|/p /|ERR|/p /|EMER|/p" ovs-vswitchd.log
Since 4a6a4734622e ("netlink-socket: Log extack error messages in netlink transactions."), tests fail on older systems that don't support NETLINK_EXT_ACK. It's not really an issue, so we can just ignore the log. CC: Paolo Valerio <pvalerio@redhat.com> CC: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- tests/ofproto-macros.at | 2 ++ tests/ovs-vswitchd.at | 2 ++ 2 files changed, 4 insertions(+)