diff mbox series

[ovs-dev,13/13] vtep: use _SAFE iterator if freing the iterator

Message ID 20220124103445.2459400-14-amorenoz@redhat.com
State Superseded
Headers show
Series Fix undefined behavior in loop macros | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning

Commit Message

Adrian Moreno Jan. 24, 2022, 10:34 a.m. UTC 
The _SAFE version of the iterator allows the user to free the iterator
structure safely.

Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
---
 vtep/vtep-ctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

0-day Robot Jan. 24, 2022, 12:05 p.m. UTC | #1 
Bleep bloop.  Greetings Adrian Moreno, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


Patch skipped due to previous failure.

Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
index 99c4adcd5..685b0007a 100644
--- a/vtep/vtep-ctl.c
+++ b/vtep/vtep-ctl.c
@@ -738,7 +738,7 @@  del_ploc_from_mcast_mac(struct vtep_ctl_mcast_mac *mcast_mac,
 {
     struct vtep_ctl_ploc *ploc;
 
-    LIST_FOR_EACH (ploc, locators_node, &mcast_mac->locators) {
+    LIST_FOR_EACH_SAFE (ploc, locators_node, &mcast_mac->locators) {
         if (ploc->ploc_cfg == ploc_cfg) {
             ovs_list_remove(&ploc->locators_node);
             free(ploc);