From patchwork Wed Dec 8 07:59:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pai G, Sunil" X-Patchwork-Id: 1565131 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4J88hm1gz6z9sRN for ; Wed, 8 Dec 2021 18:59:51 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BDD1B41D8F; Wed, 8 Dec 2021 07:59:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DHeV04o73nOj; Wed, 8 Dec 2021 07:59:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2959F41D82; Wed, 8 Dec 2021 07:59:48 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 03952C002F; Wed, 8 Dec 2021 07:59:48 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id EC7F4C0012 for ; Wed, 8 Dec 2021 07:59:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D585E41D85 for ; Wed, 8 Dec 2021 07:59:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OEt9Y6e8vyvu for ; Wed, 8 Dec 2021 07:59:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4813B41D82 for ; Wed, 8 Dec 2021 07:59:46 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10191"; a="238007135" X-IronPort-AV: E=Sophos;i="5.87,296,1631602800"; d="scan'208";a="238007135" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2021 23:59:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,296,1631602800"; d="scan'208";a="679804975" Received: from silpixa00400896.ir.intel.com ([10.243.23.14]) by orsmga005.jf.intel.com with ESMTP; 07 Dec 2021 23:59:44 -0800 From: Sunil Pai G To: dev@openvswitch.org Date: Wed, 8 Dec 2021 07:59:40 +0000 Message-Id: <20211208075940.1577852-1-sunil.pai.g@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211208075317.1577200-1-sunil.pai.g@intel.com> References: <20211208075317.1577200-1-sunil.pai.g@intel.com> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH v3] acinclude: Provide better error info when linking fails with DPDK. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Currently, on failure to link with DPDK, the configure script provides an error message to update the PKG_CONFIG_PATH even though the cause of failure was missing dependencies. Improve the error message to include this scenario. Signed-off-by: Sunil Pai G --- v2-> v3: Fix sentence. v1-> v2: Improve logging instead of printing contents from config.log --- acinclude.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index dba365ea1..15391e68d 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -486,7 +486,8 @@ AC_DEFUN([OVS_CHECK_DPDK], [ DPDKLIB_FOUND=true], [AC_MSG_RESULT([no]) AC_MSG_ERROR(m4_normalize([ - Could not find DPDK library in default search path, update + Failed to link with DPDK, check config.log for more details. + Could not find working DPDK library in default search path, update PKG_CONFIG_PATH for pkg-config to find the .pc file in non-standard location])) ])