| Message ID | 20211008115748.30890-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] github: Remove workaround fixing up /etc/hosts. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On Fri, Oct 8, 2021 at 1:58 PM Dumitru Ceara <dceara@redhat.com> wrote: > > The issue that was worked around has been fixed in the meantime: > https://github.com/actions/virtual-environments/issues/3353 > > Signed-off-by: Dumitru Ceara <dceara@redhat.com> Fairly trivial and ovsrobot already confirmed it was ok. I had a look at a build of mine in GHA yesterday: Run cat /etc/hosts 127.0.0.1 localhost # The following lines are desirable for IPv6 capable hosts ::1 localhost ip6-localhost ip6-loopback fe00::0 ip6-localnet ff00::0 ip6-mcastprefix ff02::1 ip6-allnodes ff02::2 ip6-allrouters ff02::3 ip6-allhosts 127.0.0.1 cpu-pool.com 127.0.0.1 MiningMadness.com 127.0.0.1 stratum-na.rplant.xyz 127.0.0.1 do-dear.com 127.0.0.1 web.do-dear.com 127.0.0.1 git.workflows.live 10.1.0.4 fv-az212-793.lkxvw04jkbfendtxnazko3bsjf.jx.internal.cloudapp.net fv-az212-793 Which looks good. Reviewed-by: David Marchand <david.marchand@redhat.com>
On 10/13/21 16:11, David Marchand wrote: > On Fri, Oct 8, 2021 at 1:58 PM Dumitru Ceara <dceara@redhat.com> wrote: >> >> The issue that was worked around has been fixed in the meantime: >> https://github.com/actions/virtual-environments/issues/3353 >> >> Signed-off-by: Dumitru Ceara <dceara@redhat.com> > > Fairly trivial and ovsrobot already confirmed it was ok. > > I had a look at a build of mine in GHA yesterday: > > Run cat /etc/hosts > 127.0.0.1 localhost > # The following lines are desirable for IPv6 capable hosts > ::1 localhost ip6-localhost ip6-loopback > fe00::0 ip6-localnet > ff00::0 ip6-mcastprefix > ff02::1 ip6-allnodes > ff02::2 ip6-allrouters > ff02::3 ip6-allhosts > 127.0.0.1 cpu-pool.com > 127.0.0.1 MiningMadness.com > 127.0.0.1 stratum-na.rplant.xyz > 127.0.0.1 do-dear.com > 127.0.0.1 web.do-dear.com > 127.0.0.1 git.workflows.live > 10.1.0.4 fv-az212-793.lkxvw04jkbfendtxnazko3bsjf.jx.internal.cloudapp.net > fv-az212-793 > > Which looks good. > > Reviewed-by: David Marchand <david.marchand@redhat.com> Applied. Thanks! Best regards, Ilya Maximets.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index e2350c6d9dc1..ce98a9f98f04 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -113,12 +113,6 @@ jobs: - name: checkout uses: actions/checkout@v2 - - name: fix up /etc/hosts - # https://github.com/actions/virtual-environments/issues/3353 - run: | - cat /etc/hosts - sudo sed -i "/don't remove this line/d" /etc/hosts || true - - name: update PATH run: | echo "$HOME/bin" >> $GITHUB_PATH
The issue that was worked around has been fixed in the meantime: https://github.com/actions/virtual-environments/issues/3353 Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- .github/workflows/build-and-test.yml | 6 ------ 1 file changed, 6 deletions(-)