diff mbox series

[ovs-dev,v2,1/3] northd: Disable parallel processing for logical_dp_groups

Message ID 20210826084635.23209-1-anton.ivanov@cambridgegreys.com
State Not Applicable
Headers show
Series [ovs-dev,v2,1/3] northd: Disable parallel processing for logical_dp_groups | expand

Checks

Context Check Description
ovsrobot/apply-robot fail apply and check: fail

Commit Message

Anton Ivanov Aug. 26, 2021, 8:46 a.m. UTC 
From: Anton Ivanov <anton.ivanov@cambridgegreys.com>

Work on improving processing with dp_groups enabled has
discovered that the locking mechanism presently in use
is not reliable. Disabling parallel processing if dp_groups
are enabled until the root cause is determined and fixed.

Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
---
 northd/ovn-northd.c | 2 +-
 ovs                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

0-day Robot Aug. 26, 2021, 8:56 a.m. UTC | #1 
Bleep bloop.  Greetings Anton Ivanov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


git-am:
error: sha1 information is lacking or useless (northd/ovn-northd.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 northd: Disable parallel processing for logical_dp_groups
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Patch skipped due to previous failure.

Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index af413aba4..8c653cf52 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -12861,7 +12861,7 @@  build_lswitch_and_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
         }
     }
 
-    if (use_parallel_build) {
+    if (use_parallel_build && (!use_logical_dp_groups)) {
         struct hmap *lflow_segs;
         struct lswitch_flow_build_info *lsiv;
         int index;