| Message ID | 20210813145206.21551-1-suneetha.kalahasthi@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev,branch-master] OVS: Update OVS master to use latest dpdk versions | expand |
On 8/13/21 4:52 PM, Suneetha Kalahasthi wrote: > Modify ci linux build script to use the latest DPDK stable release 20.11.2. > Modify Documentation to use the latest DPDK stable release 20.11.2. > Update NEWS file to reflect the latest DPDK stable release 20.11.2. > FAQ is updated to reflect the latest DPDK for each OVS branch. > > Signed-off-by: Suneetha Kalahasthi <suneetha.kalahasthi@intel.com> > --- Hi. Thanks for the patch! Few notes about the subject line: 1. Please, don't put 'branch-master' into the subject prefix. master is a default branch, so it should be just '[PATCH]'. 2. The patch name is not informative and 'OVS: Update OVS master' part doesn't make much sense, just because it is obviously OVS and the branch will be defined by the fact where the patch will be applied. The 'area' prefix should be 'dpdk:' insted of 'OVS:'. In general, I'd suggest to follow the pattern of previous patches like this one and name the patch: dpdk: Use DPDK 20.11.2 release. One more comment inline. Best regards, Ilya Maximets. > .ci/linux-build.sh | 2 +- > Documentation/faq/releases.rst | 8 ++++---- > Documentation/intro/install/dpdk.rst | 8 ++++---- > NEWS | 2 +- > 4 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > index 863f02388..ef6b5fd4b 100755 > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > @@ -216,7 +216,7 @@ fi > > if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then > if [ -z "$DPDK_VER" ]; then > - DPDK_VER="20.11.1" > + DPDK_VER="20.11.2" > fi > install_dpdk $DPDK_VER > if [ "$CC" = "clang" ]; then > diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst > index 68c9867b1..5d52446b9 100644 > --- a/Documentation/faq/releases.rst > +++ b/Documentation/faq/releases.rst > @@ -205,10 +205,10 @@ Q: What DPDK version does each Open vSwitch release work with? > 2.10.x 17.11.10 > 2.11.x 18.11.9 > 2.12.x 18.11.9 > - 2.13.x 19.11.8 > - 2.14.x 19.11.8 > - 2.15.x 20.11.1 > - 2.16.x 20.11.1 > + 2.13.x 19.11.9 > + 2.14.x 19.11.9 > + 2.15.x 20.11.2 > + 2.16.x 20.11.2 > ============ ======== You're updating versions for branches 2.14 and 2.13, but I don't see patches that are actually doing that on the corresponding branches. I'd expect patches for all branches to be accepted at the same time or in ascending order starting from the oldest branch. > > Q: Are all the DPDK releases that OVS versions work with maintained? > diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst > index 96843af73..d23a55c2c 100644 > --- a/Documentation/intro/install/dpdk.rst > +++ b/Documentation/intro/install/dpdk.rst > @@ -42,7 +42,7 @@ Build requirements > In addition to the requirements described in :doc:`general`, building Open > vSwitch with DPDK will require the following: > > -- DPDK 20.11.1 > +- DPDK 20.11.2 > > - A `DPDK supported NIC`_ > > @@ -73,9 +73,9 @@ Install DPDK > #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: > > $ cd /usr/src/ > - $ wget https://fast.dpdk.org/rel/dpdk-20.11.1.tar.xz > - $ tar xf dpdk-20.11.1.tar.xz > - $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.1 > + $ wget https://fast.dpdk.org/rel/dpdk-20.11.2.tar.xz > + $ tar xf dpdk-20.11.2.tar.xz > + $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.2 > $ cd $DPDK_DIR > > #. Configure and install DPDK using Meson > diff --git a/NEWS b/NEWS > index 26920e215..53d8ce977 100644 > --- a/NEWS > +++ b/NEWS > @@ -73,7 +73,7 @@ v2.16.0 - xx xxx xxxx > in ovsdb on startup. > * New command 'record-hostname-if-not-set' to update hostname in ovsdb. > - DPDK: > - * OVS validated with DPDK 20.11.1. It is recommended to use this version > + * OVS validated with DPDK 20.11.2. It is recommended to use this version > until further releases. > * New debug appctl command 'dpdk/get-malloc-stats'. > * Add hardware offload support for tunnel pop action (experimental). >
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index 863f02388..ef6b5fd4b 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -216,7 +216,7 @@ fi if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then if [ -z "$DPDK_VER" ]; then - DPDK_VER="20.11.1" + DPDK_VER="20.11.2" fi install_dpdk $DPDK_VER if [ "$CC" = "clang" ]; then diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 68c9867b1..5d52446b9 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@ -205,10 +205,10 @@ Q: What DPDK version does each Open vSwitch release work with? 2.10.x 17.11.10 2.11.x 18.11.9 2.12.x 18.11.9 - 2.13.x 19.11.8 - 2.14.x 19.11.8 - 2.15.x 20.11.1 - 2.16.x 20.11.1 + 2.13.x 19.11.9 + 2.14.x 19.11.9 + 2.15.x 20.11.2 + 2.16.x 20.11.2 ============ ======== Q: Are all the DPDK releases that OVS versions work with maintained? diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst index 96843af73..d23a55c2c 100644 --- a/Documentation/intro/install/dpdk.rst +++ b/Documentation/intro/install/dpdk.rst @@ -42,7 +42,7 @@ Build requirements In addition to the requirements described in :doc:`general`, building Open vSwitch with DPDK will require the following: -- DPDK 20.11.1 +- DPDK 20.11.2 - A `DPDK supported NIC`_ @@ -73,9 +73,9 @@ Install DPDK #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``:: $ cd /usr/src/ - $ wget https://fast.dpdk.org/rel/dpdk-20.11.1.tar.xz - $ tar xf dpdk-20.11.1.tar.xz - $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.1 + $ wget https://fast.dpdk.org/rel/dpdk-20.11.2.tar.xz + $ tar xf dpdk-20.11.2.tar.xz + $ export DPDK_DIR=/usr/src/dpdk-stable-20.11.2 $ cd $DPDK_DIR #. Configure and install DPDK using Meson diff --git a/NEWS b/NEWS index 26920e215..53d8ce977 100644 --- a/NEWS +++ b/NEWS @@ -73,7 +73,7 @@ v2.16.0 - xx xxx xxxx in ovsdb on startup. * New command 'record-hostname-if-not-set' to update hostname in ovsdb. - DPDK: - * OVS validated with DPDK 20.11.1. It is recommended to use this version + * OVS validated with DPDK 20.11.2. It is recommended to use this version until further releases. * New debug appctl command 'dpdk/get-malloc-stats'. * Add hardware offload support for tunnel pop action (experimental).
Modify ci linux build script to use the latest DPDK stable release 20.11.2. Modify Documentation to use the latest DPDK stable release 20.11.2. Update NEWS file to reflect the latest DPDK stable release 20.11.2. FAQ is updated to reflect the latest DPDK for each OVS branch. Signed-off-by: Suneetha Kalahasthi <suneetha.kalahasthi@intel.com> --- .ci/linux-build.sh | 2 +- Documentation/faq/releases.rst | 8 ++++---- Documentation/intro/install/dpdk.rst | 8 ++++---- NEWS | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-)