| Message ID | 20210415024504.2823000-1-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] mac-learning: Remove obsolete comments about tags. | expand |
This comment-only patch could use a review. On Wed, Apr 14, 2021 at 07:45:04PM -0700, Ben Pfaff wrote: > Commit a14502a7c529 ("classifier: Retire partitions.") in 2015 removed > OVS support for tags for the second time (!), so these comments about > them should be removed too. > > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > lib/mac-learning.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/lib/mac-learning.c b/lib/mac-learning.c > index 9442858d95c3..3d5293d3b34c 100644 > --- a/lib/mac-learning.c > +++ b/lib/mac-learning.c > @@ -491,12 +491,8 @@ mac_learning_lookup(const struct mac_learning *ml, > const struct eth_addr dst, uint16_t vlan) > { > if (eth_addr_is_multicast(dst)) { > - /* No tag because the treatment of multicast destinations never > - * changes. */ > return NULL; > } else if (!is_learning_vlan(ml, vlan)) { > - /* We don't tag this property. The set of learning VLANs changes so > - * rarely that we revalidate every flow when it changes. */ > return NULL; > } else { > struct mac_entry *e = mac_entry_lookup(ml, dst, vlan); > -- > 2.29.2 >
On 4/15/21 4:45 AM, Ben Pfaff wrote: > Commit a14502a7c529 ("classifier: Retire partitions.") in 2015 removed > OVS support for tags for the second time (!), so these comments about > them should be removed too. > > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- Acked-by: Ilya Maximets <i.maximets@ovn.org>
On Wed, May 12, 2021 at 10:03:43PM +0200, Ilya Maximets wrote: > On 4/15/21 4:45 AM, Ben Pfaff wrote: > > Commit a14502a7c529 ("classifier: Retire partitions.") in 2015 removed > > OVS support for tags for the second time (!), so these comments about > > them should be removed too. > > > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > Acked-by: Ilya Maximets <i.maximets@ovn.org> Thanks! I applied this to master.
diff --git a/lib/mac-learning.c b/lib/mac-learning.c index 9442858d95c3..3d5293d3b34c 100644 --- a/lib/mac-learning.c +++ b/lib/mac-learning.c @@ -491,12 +491,8 @@ mac_learning_lookup(const struct mac_learning *ml, const struct eth_addr dst, uint16_t vlan) { if (eth_addr_is_multicast(dst)) { - /* No tag because the treatment of multicast destinations never - * changes. */ return NULL; } else if (!is_learning_vlan(ml, vlan)) { - /* We don't tag this property. The set of learning VLANs changes so - * rarely that we revalidate every flow when it changes. */ return NULL; } else { struct mac_entry *e = mac_entry_lookup(ml, dst, vlan);
Commit a14502a7c529 ("classifier: Retire partitions.") in 2015 removed OVS support for tags for the second time (!), so these comments about them should be removed too. Signed-off-by: Ben Pfaff <blp@ovn.org> --- lib/mac-learning.c | 4 ---- 1 file changed, 4 deletions(-)