diff mbox series

[ovs-dev,v2,01/26] ovn-northd-ddlog: Fix two memory leaks.

Message ID 20210401232108.3902274-2-blp@ovn.org
State Not Applicable
Headers show
Series ddlog 5x performance improvement | expand

Commit Message

Ben Pfaff April 1, 2021, 11:20 p.m. UTC
I get a clean report from Address Sanitizer now.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 northd/ovn-northd-ddlog.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

0-day Robot April 2, 2021, 12:57 a.m. UTC | #1
Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


git-am:
error: sha1 information is lacking or useless (northd/ovn-northd-ddlog.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 ovn-northd-ddlog: Fix two memory leaks.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c
index b7d2c8a5ef8d..ca1ab325448c 100644
--- a/northd/ovn-northd-ddlog.c
+++ b/northd/ovn-northd-ddlog.c
@@ -336,6 +336,7 @@  ddlog_commit(ddlog_prog ddlog, ddlog_delta *delta)
 
     /* Merge changes into `delta`. */
     ddlog_delta_union(delta, new_delta);
+    ddlog_free_delta(new_delta);
 
     return 0;
 }
@@ -1213,6 +1214,7 @@  main(int argc, char *argv[])
 
     char *ovn_internal_version = ovn_get_internal_version();
     VLOG_INFO("OVN internal version is : [%s]", ovn_internal_version);
+    free(ovn_internal_version);
 
     daemonize_complete();