| Message ID | 20210202174111.GW2486489@ovn.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [ovs-dev] ovn-controller doesn't bring re-added container ports up? | expand |
On Tue, Feb 2, 2021 at 11:11 PM Ben Pfaff <blp@ovn.org> wrote: > > The test "ovn -- nested containers" adds, removes, and then re-adds a > container port bar2. It appears to me that ovn-controller never brings > the re-added port up. I don't know why. > > To see the problem, apply the following patch then run that test > (currently test 88): Hi Ben, Thanks for reporting this. I was able to reproduce locally. Let me debug further and get back to you. Thanks Numan > > diff --git a/tests/ovn.at b/tests/ovn.at > index e011263838d4..b1e04ac16b4c 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -8988,9 +8988,9 @@ bar2_zoneid=$(as hv2 ovs-vsctl get bridge br-int external_ids:ct-zone-bar2) > AT_CHECK([test -z $bar2_zoneid]) > > # Add back bar2 > -wait_for_ports_up > ovn-nbctl lsp-add bar bar2 vm2 1 \ > -- lsp-set-addresses bar2 "f0:00:00:01:02:08 192.168.2.3" > +wait_for_ports_up > ovn-nbctl --wait=hv sync > > bar2_zoneid=$(as hv2 ovs-vsctl get bridge br-int external_ids:ct-zone-bar2) > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On Tue, Feb 2, 2021 at 11:26 PM Numan Siddique <numans@ovn.org> wrote: > > On Tue, Feb 2, 2021 at 11:11 PM Ben Pfaff <blp@ovn.org> wrote: > > > > The test "ovn -- nested containers" adds, removes, and then re-adds a > > container port bar2. It appears to me that ovn-controller never brings > > the re-added port up. I don't know why. > > > > To see the problem, apply the following patch then run that test > > (currently test 88): > > Hi Ben, > > Thanks for reporting this. I was able to reproduce locally. Let me debug > further and get back to you. > This regression is seen after the commit [1]. Dumitru submitted a patch today [2] to fix an issue introduced by [1] and looks like his patch doesn't address this particular issue. @Dumitru - Can you also please address the issue reported here in your patch. [1] - 4d3cb42b07 ("binding: Set Logical_Switch_Port.up when all OVS flows are installed.") [2] - https://patchwork.ozlabs.org/project/ovn/patch/1612259114-30311-1-git-send-email-dceara@redhat.com/ Thanks Numan > Thanks > Numan > > > > > diff --git a/tests/ovn.at b/tests/ovn.at > > index e011263838d4..b1e04ac16b4c 100644 > > --- a/tests/ovn.at > > +++ b/tests/ovn.at > > @@ -8988,9 +8988,9 @@ bar2_zoneid=$(as hv2 ovs-vsctl get bridge br-int external_ids:ct-zone-bar2) > > AT_CHECK([test -z $bar2_zoneid]) > > > > # Add back bar2 > > -wait_for_ports_up > > ovn-nbctl lsp-add bar bar2 vm2 1 \ > > -- lsp-set-addresses bar2 "f0:00:00:01:02:08 192.168.2.3" > > +wait_for_ports_up > > ovn-nbctl --wait=hv sync > > > > bar2_zoneid=$(as hv2 ovs-vsctl get bridge br-int external_ids:ct-zone-bar2) > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
On 2/2/21 7:18 PM, Numan Siddique wrote: > On Tue, Feb 2, 2021 at 11:26 PM Numan Siddique <numans@ovn.org> wrote: >> >> On Tue, Feb 2, 2021 at 11:11 PM Ben Pfaff <blp@ovn.org> wrote: >>> >>> The test "ovn -- nested containers" adds, removes, and then re-adds a >>> container port bar2. It appears to me that ovn-controller never brings >>> the re-added port up. I don't know why. >>> >>> To see the problem, apply the following patch then run that test >>> (currently test 88): >> >> Hi Ben, >> >> Thanks for reporting this. I was able to reproduce locally. Let me debug >> further and get back to you. >> > > This regression is seen after the commit [1]. Oops, sorry about that. > > Dumitru submitted a patch today [2] to fix an issue introduced by [1] > and looks like his patch > doesn't address this particular issue. > > @Dumitru - Can you also please address the issue reported here in your patch. Sure I'll send a v2 after I fix the container port issue too. Thanks, Dumitru > > [1] - 4d3cb42b07 ("binding: Set Logical_Switch_Port.up when all OVS > flows are installed.") > [2] - https://patchwork.ozlabs.org/project/ovn/patch/1612259114-30311-1-git-send-email-dceara@redhat.com/ > > Thanks > Numan > >> Thanks >> Numan >> >>> >>> diff --git a/tests/ovn.at b/tests/ovn.at >>> index e011263838d4..b1e04ac16b4c 100644 >>> --- a/tests/ovn.at >>> +++ b/tests/ovn.at >>> @@ -8988,9 +8988,9 @@ bar2_zoneid=$(as hv2 ovs-vsctl get bridge br-int external_ids:ct-zone-bar2) >>> AT_CHECK([test -z $bar2_zoneid]) >>> >>> # Add back bar2 >>> -wait_for_ports_up >>> ovn-nbctl lsp-add bar bar2 vm2 1 \ >>> -- lsp-set-addresses bar2 "f0:00:00:01:02:08 192.168.2.3" >>> +wait_for_ports_up >>> ovn-nbctl --wait=hv sync >>> >>> bar2_zoneid=$(as hv2 ovs-vsctl get bridge br-int external_ids:ct-zone-bar2) >>> _______________________________________________ >>> dev mailing list >>> dev@openvswitch.org >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>> >
On 2/2/21 8:17 PM, Dumitru Ceara wrote: > On 2/2/21 7:18 PM, Numan Siddique wrote: >> On Tue, Feb 2, 2021 at 11:26 PM Numan Siddique <numans@ovn.org> wrote: >>> >>> On Tue, Feb 2, 2021 at 11:11 PM Ben Pfaff <blp@ovn.org> wrote: >>>> >>>> The test "ovn -- nested containers" adds, removes, and then re-adds a >>>> container port bar2. It appears to me that ovn-controller never brings >>>> the re-added port up. I don't know why. >>>> >>>> To see the problem, apply the following patch then run that test >>>> (currently test 88): >>> >>> Hi Ben, >>> >>> Thanks for reporting this. I was able to reproduce locally. Let me debug >>> further and get back to you. >>> >> >> This regression is seen after the commit [1]. > > Oops, sorry about that. > >> >> Dumitru submitted a patch today [2] to fix an issue introduced by [1] >> and looks like his patch >> doesn't address this particular issue. >> >> @Dumitru - Can you also please address the issue reported here in your >> patch. > > Sure I'll send a v2 after I fix the container port issue too. Hi Ben, Numan, I sent a v2: http://patchwork.ozlabs.org/project/ovn/list/?series=227836 The first patch of the set fixes the problem Ben reported. The other two patches fix the functionality during upgrade. Regards, Dumitru > > Thanks, > Dumitru > >> >> [1] - 4d3cb42b07 ("binding: Set Logical_Switch_Port.up when all OVS >> flows are installed.") >> [2] - >> https://patchwork.ozlabs.org/project/ovn/patch/1612259114-30311-1-git-send-email-dceara@redhat.com/ >>
diff --git a/tests/ovn.at b/tests/ovn.at index e011263838d4..b1e04ac16b4c 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -8988,9 +8988,9 @@ bar2_zoneid=$(as hv2 ovs-vsctl get bridge br-int external_ids:ct-zone-bar2) AT_CHECK([test -z $bar2_zoneid]) # Add back bar2 -wait_for_ports_up ovn-nbctl lsp-add bar bar2 vm2 1 \ -- lsp-set-addresses bar2 "f0:00:00:01:02:08 192.168.2.3" +wait_for_ports_up ovn-nbctl --wait=hv sync bar2_zoneid=$(as hv2 ovs-vsctl get bridge br-int external_ids:ct-zone-bar2)