Message ID | 20210105185902.3922928-6-olteanv@gmail.com |
---|---|
State | Awaiting Upstream |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=qumLfxH/; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D9MVp0GnWz9sSC for <incoming@patchwork.ozlabs.org>; Wed, 6 Jan 2021 06:09:22 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E3B54863BB; Tue, 5 Jan 2021 19:09:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JdhZBAZdLEwr; Tue, 5 Jan 2021 19:09:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 554BC86375; Tue, 5 Jan 2021 19:09:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 18065C08A1; Tue, 5 Jan 2021 19:09:11 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5DCDAC013A for <dev@openvswitch.org>; Tue, 5 Jan 2021 19:00:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 49E0120353 for <dev@openvswitch.org>; Tue, 5 Jan 2021 19:00:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6EEfBlxbjME3 for <dev@openvswitch.org>; Tue, 5 Jan 2021 19:00:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by silver.osuosl.org (Postfix) with ESMTPS id 57AA6203F3 for <dev@openvswitch.org>; Tue, 5 Jan 2021 19:00:55 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id h16so1866110edt.7 for <dev@openvswitch.org>; Tue, 05 Jan 2021 11:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GLvxCKLmR2t5WVjRUZehiWKIjudvryuha5j5MLp+E+U=; b=qumLfxH/uosKGVeB1d+uK3MGmbPBDq3Tefsa6LeB4yOaqE4sDVmjq8n88J3Af9SWID zE/OzdCWUBmYqSDveMUrnjfExUwlKcXIKocVP4DRlKfB8X7dPGqH22aeXXE/q6RuD9Zb LQwfxmfEdGl3TbU+0kKPfiVdt/xC2UzgwNEoAb2tjMddMwrS4DBZLCzfkVXqKzIo0zW3 CP9CZwsQphbG9aViNf0hnIKUqOBDi3ElTHZlnmNm2VBSM393jCAQK5YMPuys8IGY0V7X +dfIzPdUu6R7MiLk9T5blM730FvW/A6il2bYDlUbIgzJ1vBpdu7ow9UXKeZzSiAcXlmL 98eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GLvxCKLmR2t5WVjRUZehiWKIjudvryuha5j5MLp+E+U=; b=Qz42jK4P69sah6TDB7RimePLxQXf1sgIHPWFpuIf2sdfsp2B/sIt/zBg5IXW9g4F9P 7Ceynu2PWjYScH5gBMz1KsKW5eEqeqQOIX/cBRXDuM/gFl/VE88IbhmmiwBcFolkvG+Y meMEF6Fha1cG+WLm/IZlY08hSR39mNEaGBgE9HNRqXKQ7NydT76xV4W0D1ym17j/SNve lZ2ec7V92nStbvytne0NF2C4HkLkDnKc/o25kweQe9WRDQ+zMDFyWs19QSxi1FUmU1nu 1Vx+9Pidpo67ZnNxf+W5FkSqP/fvPPwCrutiGRatRM0q6MOT62A7sze5CaddODMcZ4av wW9w== X-Gm-Message-State: AOAM533mWwmhxr2aUKarB8imm4I5a9oyd/MBETd2IYlbrGSJmzOmHz8c 75XAHbIUee+xyWH+q9ViyZU= X-Google-Smtp-Source: ABdhPJy8kPqxEk8FQReSydm1oqxA729aS1Dqn6n2NIipxNBNdXArGt1146Pufkl9aVpc3ocJnHwq7g== X-Received: by 2002:a05:6402:3546:: with SMTP id f6mr1184932edd.242.1609873253835; Tue, 05 Jan 2021 11:00:53 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id z13sm205084edq.48.2021.01.05.11.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 11:00:53 -0800 (PST) From: Vladimir Oltean <olteanv@gmail.com> To: "David S . Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org> Date: Tue, 5 Jan 2021 20:58:55 +0200 Message-Id: <20210105185902.3922928-6-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210105185902.3922928-1-olteanv@gmail.com> References: <20210105185902.3922928-1-olteanv@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 05 Jan 2021 19:09:06 +0000 Cc: Andrew Lunn <andrew@lunn.ch>, Alexei Starovoitov <ast@kernel.org>, George McCollister <george.mccollister@gmail.com>, Eric Dumazet <edumazet@google.com>, Christian Brauner <christian.brauner@ubuntu.com>, Andy Gospodarek <andy@greyhouse.net>, dev@openvswitch.org, linux-s390@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>, Daniel Borkmann <daniel@iogearbox.net>, Oleksij Rempel <o.rempel@pengutronix.de>, Veaceslav Falico <vfalico@gmail.com>, intel-wired-lan@lists.osuosl.org, =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@intel.com>, Andrii Nakryiko <andriin@fb.com>, Pablo Neira Ayuso <pablo@netfilter.org>, Arnd Bergmann <arnd@arndb.de>, Jay Vosburgh <j.vosburgh@gmail.com>, Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Benc <jbenc@redhat.com>, Jiri Pirko <jiri@mellanox.com>, Cong Wang <xiyou.wangcong@gmail.com>, Paolo Abeni <pabeni@redhat.com>, linux-scsi@vger.kernel.org, linux-parisc@vger.kernel.org, Paul Gortmaker <paul.gortmaker@windriver.com>, netdev@vger.kernel.org, linux-usb@vger.kernel.org, Florian Westphal <fw@strlen.de>, Stephen Hemminger <stephen@networkplumber.org> Subject: [ovs-dev] [RFC PATCH v2 net-next 05/12] s390/appldata_net_sum: hold the netdev lists lock when retrieving device statistics X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" <ovs-dev-bounces@openvswitch.org> |
Series |
Make .ndo_get_stats64 sleepable
|
expand
|
diff --git a/arch/s390/appldata/appldata_net_sum.c b/arch/s390/appldata/appldata_net_sum.c index 59c282ca002f..4db886980cba 100644 --- a/arch/s390/appldata/appldata_net_sum.c +++ b/arch/s390/appldata/appldata_net_sum.c @@ -78,8 +78,9 @@ static void appldata_get_net_sum_data(void *data) tx_dropped = 0; collisions = 0; - rcu_read_lock(); - for_each_netdev_rcu(&init_net, dev) { + netif_lists_lock(&init_net); + + for_each_netdev(&init_net, dev) { const struct rtnl_link_stats64 *stats; struct rtnl_link_stats64 temp; @@ -95,7 +96,8 @@ static void appldata_get_net_sum_data(void *data) collisions += stats->collisions; i++; } - rcu_read_unlock(); + + netif_lists_unlock(&init_net); net_data->nr_interfaces = i; net_data->rx_packets = rx_packets;