| Message ID | 20201224093858.1455190-3-mark.d.gray@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ipsec: Various fixes for ovs-monitor-ipsec | expand |
On Thu, Dec 24, 2020 at 04:38:56AM -0500, Mark Gray wrote: > Check for pidfile before attempting 'exit'. If pidfile does > not exist, we cannot cleanly exit so kill process. Hi Mark, It looks like the commit message needs update, otherwise the patch looks okay to me. fbl > > Signed-off-by: Mark Gray <mark.d.gray@redhat.com> > Acked-by: Eelco Chaudron <echaudro@redhat.com> > --- > v2: Use 'stop_daemon' > > utilities/ovs-ctl.in | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in > index 8c5cd703274e..39375f4d2ab7 100644 > --- a/utilities/ovs-ctl.in > +++ b/utilities/ovs-ctl.in > @@ -254,8 +254,7 @@ stop_forwarding () { > } > > stop_ovs_ipsec () { > - ${bindir}/ovs-appctl -t ovs-monitor-ipsec exit || return 1 > - return 0 > + stop_daemon ovs-monitor-ipsec > } > > ## --------------- ## > -- > 2.26.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index 8c5cd703274e..39375f4d2ab7 100644 --- a/utilities/ovs-ctl.in +++ b/utilities/ovs-ctl.in @@ -254,8 +254,7 @@ stop_forwarding () { } stop_ovs_ipsec () { - ${bindir}/ovs-appctl -t ovs-monitor-ipsec exit || return 1 - return 0 + stop_daemon ovs-monitor-ipsec } ## --------------- ##