| Message ID | 20201219084030.391-1-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] github: fix Ubuntu package installation | expand |
On 12/19/20 9:40 AM, David Marchand wrote: > Before trying to install a package, APT cache must be updated to avoid > asking for an unavailable version of a package. > > Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.") > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > I noticed this issue on DPDK side and I can see jobs for the OVS master > branch are affected too: > https://github.com/openvswitch/ovs/runs/1580144616?check_suite_focus=true#step:8:209 > > --- > .github/workflows/build-and-test.yml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml > index c830661383..b29c300c55 100644 > --- a/.github/workflows/build-and-test.yml > +++ b/.github/workflows/build-and-test.yml > @@ -133,6 +133,8 @@ jobs: > path: dpdk-dir > key: ${{ env.matrix_key }}-${{ env.ci_key }} > > + - name: update APT cache > + run: sudo apt update > - name: install common dependencies > if: matrix.deb_package == '' > run: sudo apt install -y ${{ env.dependencies }} > Thanks! Applied to master and backported down to 2.12. On branch-2.11 and below we're using ubuntu-16.04 and I see lots of failures during 'apt update' because of some postgresql repo: https://github.com/igsilya/ovs/runs/1589217890?check_suite_focus=true#step:3:69 So I didn't backport this fix there. best regards, Ilya Maximets.
On Mon, Dec 21, 2020 at 8:25 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > On 12/19/20 9:40 AM, David Marchand wrote: > > Before trying to install a package, APT cache must be updated to avoid > > asking for an unavailable version of a package. > > > > Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.") > > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > --- > > I noticed this issue on DPDK side and I can see jobs for the OVS master > > branch are affected too: > > https://github.com/openvswitch/ovs/runs/1580144616?check_suite_focus=true#step:8:209 > > > > --- > > .github/workflows/build-and-test.yml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml > > index c830661383..b29c300c55 100644 > > --- a/.github/workflows/build-and-test.yml > > +++ b/.github/workflows/build-and-test.yml > > @@ -133,6 +133,8 @@ jobs: > > path: dpdk-dir > > key: ${{ env.matrix_key }}-${{ env.ci_key }} > > > > + - name: update APT cache > > + run: sudo apt update > > - name: install common dependencies > > if: matrix.deb_package == '' > > run: sudo apt install -y ${{ env.dependencies }} > > > > Thanks! > > Applied to master and backported down to 2.12. > > On branch-2.11 and below we're using ubuntu-16.04 and I see lots of > failures during 'apt update' because of some postgresql repo: > https://github.com/igsilya/ovs/runs/1589217890?check_suite_focus=true#step:3:69 > So I didn't backport this fix there. Hi David, This patch is also required for OVN and I was able to cherry-pick this patch from ovs to OVN without much trouble. So I cherry-picked it, resolved the conflict and applied to OVN master and other branches - https://github.com/ovn-org/ovn/commit/119dcbeb1205aad002953e1ecef154c775912b42 Hope it's fine with you. Thanks Numan > > best regards, Ilya Maximets. > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On Mon, Dec 21, 2020 at 4:42 PM Numan Siddique <numans@ovn.org> wrote: > Hi David, > > This patch is also required for OVN and I was able to cherry-pick this > patch from ovs > to OVN without much trouble. So I cherry-picked it, resolved the > conflict and applied to OVN master > and other branches - > https://github.com/ovn-org/ovn/commit/119dcbeb1205aad002953e1ecef154c775912b42 > > Hope it's fine with you. Sure.
On 12/21/20 3:55 PM, Ilya Maximets wrote: > On 12/19/20 9:40 AM, David Marchand wrote: >> Before trying to install a package, APT cache must be updated to avoid >> asking for an unavailable version of a package. >> >> Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.") >> >> Signed-off-by: David Marchand <david.marchand@redhat.com> >> --- >> I noticed this issue on DPDK side and I can see jobs for the OVS master >> branch are affected too: >> https://github.com/openvswitch/ovs/runs/1580144616?check_suite_focus=true#step:8:209 >> >> --- >> .github/workflows/build-and-test.yml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml >> index c830661383..b29c300c55 100644 >> --- a/.github/workflows/build-and-test.yml >> +++ b/.github/workflows/build-and-test.yml >> @@ -133,6 +133,8 @@ jobs: >> path: dpdk-dir >> key: ${{ env.matrix_key }}-${{ env.ci_key }} >> >> + - name: update APT cache >> + run: sudo apt update >> - name: install common dependencies >> if: matrix.deb_package == '' >> run: sudo apt install -y ${{ env.dependencies }} >> > > Thanks! > > Applied to master and backported down to 2.12. > > On branch-2.11 and below we're using ubuntu-16.04 and I see lots of > failures during 'apt update' because of some postgresql repo: > https://github.com/igsilya/ovs/runs/1589217890?check_suite_focus=true#step:3:69 > So I didn't backport this fix there. Faced this issue with older branches now. In order to fix the problem with external repositories I added '|| true' to the update command and applied to branches 2.11 - 2.5. > > best regards, Ilya Maximets. >
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index c830661383..b29c300c55 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -133,6 +133,8 @@ jobs: path: dpdk-dir key: ${{ env.matrix_key }}-${{ env.ci_key }} + - name: update APT cache + run: sudo apt update - name: install common dependencies if: matrix.deb_package == '' run: sudo apt install -y ${{ env.dependencies }}
Before trying to install a package, APT cache must be updated to avoid asking for an unavailable version of a package. Fixes: 6cb2f5a630e3 ("github: Add GitHub Actions workflow.") Signed-off-by: David Marchand <david.marchand@redhat.com> --- I noticed this issue on DPDK side and I can see jobs for the OVS master branch are affected too: https://github.com/openvswitch/ovs/runs/1580144616?check_suite_focus=true#step:8:209 --- .github/workflows/build-and-test.yml | 2 ++ 1 file changed, 2 insertions(+)