diff mbox series

[ovs-dev,ovs,v1,1/4] netdev-dpdk: Allow to config isolate offload mode.

Message ID 20201214022001.84273-2-xiangxia.m.yue@gmail.com
State Deferred
Headers show
Series Support Flow Bifurcation | expand

Commit Message

Tonghao Zhang Dec. 14, 2020, 2:19 a.m. UTC 
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>

Isolated mode guarantees that all ingress traffic comes
from defined flow rules only (current and future).

Besides making ingress more deterministic, it allows PMDs
to safely reuse resources otherwise assigned to handle
the remaining traffic, such as global RSS configuration
settings, VLAN filters, MAC address entries, legacy filter API
rules and so on in order to expand the set of possible flow
rule types.

Calling this function as soon as possible after device initialization,
ideally before the first call to rte_eth_dev_configure(),
is recommended to avoid possible failures due to conflicting settings.

Once effective, leaving isolated mode may not be possible
depending on PMD implementation.

Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
 lib/netdev-dpdk.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

Comments

0-day Robot Dec. 14, 2020, 2:59 a.m. UTC | #1 
Bleep bloop.  Greetings Tonghao Zhang, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#49 FILE: lib/netdev-dpdk.c:974:
        VLOG_WARN("rte_flow_isolate was invoked unsuccessfully, mode(%d): %d\n",

Lines checked: 113, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 75dffefb8..48eb46f38 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -522,6 +522,10 @@  struct netdev_dpdk {
          * otherwise interrupt mode is used. */
         bool requested_lsc_interrupt_mode;
         bool lsc_interrupt_mode;
+        /* Allow to use hardware capable ethernet devices to
+         * split traffic between userspace and kernel space. */
+        bool requested_isolate_offload_mode;
+        bool isolate_offload_mode;
 
         /* VF configuration. */
         struct eth_addr requested_hwaddr;
@@ -965,6 +969,13 @@  dpdk_eth_dev_port_config(struct netdev_dpdk *dev, int n_rxq, int n_txq)
     struct rte_eth_dev_info info;
     uint16_t conf_mtu;
 
+    diag = rte_flow_isolate(dev->port_id, dev->isolate_offload_mode, NULL);
+    if (diag && diag != -ENOSYS) {
+        VLOG_WARN("rte_flow_isolate was invoked unsuccessfully, mode(%d): %d\n",
+                  dev->isolate_offload_mode, diag);
+        return diag;
+    }
+
     rte_eth_dev_info_get(dev->port_id, &info);
 
     /* As of DPDK 19.11, it is not allowed to set a mq_mode for
@@ -1245,6 +1256,7 @@  common_construct(struct netdev *netdev, dpdk_port_t port_no,
     dev->requested_mtu = RTE_ETHER_MTU;
     dev->max_packet_len = MTU_TO_FRAME_LEN(dev->mtu);
     dev->requested_lsc_interrupt_mode = 0;
+    dev->requested_isolate_offload_mode = 0;
     ovsrcu_index_init(&dev->vid, -1);
     dev->vhost_reconfigured = false;
     dev->attached = false;
@@ -1739,6 +1751,8 @@  netdev_dpdk_get_config(const struct netdev *netdev, struct smap *args)
         }
         smap_add(args, "lsc_interrupt_mode",
                  dev->lsc_interrupt_mode ? "true" : "false");
+        smap_add(args, "isolate_offload_mode",
+                 dev->isolate_offload_mode ? "true" : "false");
 
         if (dpdk_port_is_representor(dev)) {
             smap_add_format(args, "dpdk-vf-mac", ETH_ADDR_FMT,
@@ -1918,6 +1932,7 @@  netdev_dpdk_set_config(struct netdev *netdev, const struct smap *args,
     bool rx_fc_en, tx_fc_en, autoneg, lsc_interrupt_mode;
     bool flow_control_requested = true;
     enum rte_eth_fc_mode fc_mode;
+    bool isolate_offload_mode;
     static const enum rte_eth_fc_mode fc_mode_set[2][2] = {
         {RTE_FC_NONE,     RTE_FC_TX_PAUSE},
         {RTE_FC_RX_PAUSE, RTE_FC_FULL    }
@@ -2022,6 +2037,12 @@  netdev_dpdk_set_config(struct netdev *netdev, const struct smap *args,
         netdev_request_reconfigure(netdev);
     }
 
+    isolate_offload_mode = smap_get_bool(args, "isolate-offload-mode", false);
+    if (dev->requested_isolate_offload_mode != isolate_offload_mode) {
+        dev->requested_isolate_offload_mode = isolate_offload_mode;
+        netdev_request_reconfigure(netdev);
+    }
+
     rx_fc_en = smap_get_bool(args, "rx-flow-ctrl", false);
     tx_fc_en = smap_get_bool(args, "tx-flow-ctrl", false);
     autoneg = smap_get_bool(args, "flow-ctrl-autoneg", false);
@@ -4985,6 +5006,7 @@  netdev_dpdk_reconfigure(struct netdev *netdev)
         && netdev->n_rxq == dev->requested_n_rxq
         && dev->mtu == dev->requested_mtu
         && dev->lsc_interrupt_mode == dev->requested_lsc_interrupt_mode
+        && dev->isolate_offload_mode == dev->requested_isolate_offload_mode
         && dev->rxq_size == dev->requested_rxq_size
         && dev->txq_size == dev->requested_txq_size
         && eth_addr_equals(dev->hwaddr, dev->requested_hwaddr)
@@ -5011,6 +5033,7 @@  netdev_dpdk_reconfigure(struct netdev *netdev)
     }
 
     dev->lsc_interrupt_mode = dev->requested_lsc_interrupt_mode;
+    dev->isolate_offload_mode = dev->requested_isolate_offload_mode;
 
     netdev->n_txq = dev->requested_n_txq;
     netdev->n_rxq = dev->requested_n_rxq;