diff mbox series

[ovs-dev,net-next] net: openvswitch: conntrack: simplify the return expression of ovs_ct_limit_get_default_limit()

Message ID 20201208121353.9353-1-zhengyongjun3@huawei.com
State Awaiting Upstream
Headers show
Series [ovs-dev,net-next] net: openvswitch: conntrack: simplify the return expression of ovs_ct_limit_get_default_limit() | expand

Commit Message

Zheng Yongjun Dec. 8, 2020, 12:13 p.m. UTC
Simplify the return expression.

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 net/openvswitch/conntrack.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Eelco Chaudron Dec. 8, 2020, 1:54 p.m. UTC | #1
On 8 Dec 2020, at 13:13, Zheng Yongjun wrote:

> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Change looks good to me.

Reviewed-by: Eelco Chaudron <echaudro@redhat.com>
David Miller Dec. 9, 2020, 12:24 a.m. UTC | #2
From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Tue, 8 Dec 2020 20:13:53 +0800

> Simplify the return expression.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Applied.
diff mbox series

Patch

diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index 4beb96139d77..96a49aa3a128 100644
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -2025,15 +2025,11 @@  static int ovs_ct_limit_get_default_limit(struct ovs_ct_limit_info *info,
 					  struct sk_buff *reply)
 {
 	struct ovs_zone_limit zone_limit;
-	int err;
 
 	zone_limit.zone_id = OVS_ZONE_LIMIT_DEFAULT_ZONE;
 	zone_limit.limit = info->default_limit;
-	err = nla_put_nohdr(reply, sizeof(zone_limit), &zone_limit);
-	if (err)
-		return err;
 
-	return 0;
+	return nla_put_nohdr(reply, sizeof(zone_limit), &zone_limit);
 }
 
 static int __ovs_ct_limit_get_zone_limit(struct net *net,