diff mbox series

[ovs-dev,v6,06/11] netdev-offload-tc: Implement register sFlow upcall callback API

Message ID 20201130024541.7935-7-cmi@nvidia.com
State Superseded
Headers show
Series Add offload support for sFlow | expand

Commit Message

Chris Mi Nov. 30, 2020, 2:45 a.m. UTC 
Save the upcall callback as a pre-step towards offloading sample
action to TC.

Issue: 2181036
Change-Id: Ibbdac14c9d5183f5f42dcd6cef91aa54c08bc489
Signed-off-by: Chris Mi <cmi@nvidia.com>
Reviewed-by: Eli Britstein <elibr@nvidia.com>
---
 lib/netdev-offload-tc.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

0-day Robot Nov. 30, 2020, 3:20 a.m. UTC | #1 
Bleep bloop.  Greetings Chris Mi, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Remove Gerrit Change-Id's before submitting upstream.
9: Change-Id: Ibbdac14c9d5183f5f42dcd6cef91aa54c08bc489

Lines checked: 52, Warnings: 0, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
index 2a772a971..9c5be9f92 100644
--- a/lib/netdev-offload-tc.c
+++ b/lib/netdev-offload-tc.c
@@ -49,6 +49,8 @@  static struct hmap tc_to_ufid = HMAP_INITIALIZER(&tc_to_ufid);
 static bool multi_mask_per_prio = false;
 static bool block_support = false;
 
+static dpif_netlink_sflow_upcall_callback *upcall_cb;
+
 struct netlink_field {
     int offset;
     int flower_offset;
@@ -1985,6 +1987,12 @@  probe_tc_block_support(int ifindex)
     }
 }
 
+static void
+netdev_tc_register_sflow_upcall_cb(dpif_netlink_sflow_upcall_callback *cb)
+{
+    upcall_cb = cb;
+}
+
 static int
 netdev_tc_init_flow_api(struct netdev *netdev)
 {
@@ -2044,5 +2052,6 @@  const struct netdev_flow_api netdev_offload_tc = {
    .flow_put = netdev_tc_flow_put,
    .flow_get = netdev_tc_flow_get,
    .flow_del = netdev_tc_flow_del,
+   .register_nl_sflow_upcall_cb = netdev_tc_register_sflow_upcall_cb,
    .init_flow_api = netdev_tc_init_flow_api,
 };