| Message ID | 20200828170305.43583-3-mark.d.gray@redhat.com |
|---|---|
| State | Accepted |
| Commit | b67feabbbf66c2e08cbb50015c5961734b316c49 |
| Headers | show |
| Series | [ovs-dev,v4,1/3] id-pool: Add interface to check if id has been allocated | expand |
On Fri, Aug 28, 2020 at 06:03:05PM +0100, Mark Gray wrote: > Signed-off-by: Mark Gray <mark.d.gray@redhat.com> > --- :-) Acked-by: Flavio Leitner <fbl@sysclose.org>
On 8/28/20 7:03 PM, Mark Gray wrote: > Signed-off-by: Mark Gray <mark.d.gray@redhat.com> > --- Maybe you also want to update .mailmap? So git will know your correct e-mail address. For 'git blame' purposes. :) It also make sense to send this patch separately (not as part of a patch set) and have a bit more meaningful patch subject, e.g. have your name in it (this just simplifies automatic patch detection since there are already a bunch of equally named patches in patchwork). And since we're here, it's usually better to have a cover letter while sending patch-sets with more than one patch. And, yes, as Flavio already mentioned, please, don't send new versions in reply to old ones. Best regards, Ilya Maximets. > AUTHORS.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/AUTHORS.rst b/AUTHORS.rst > index 4d8eaa3bd..cb26e0197 100644 > --- a/AUTHORS.rst > +++ b/AUTHORS.rst > @@ -255,7 +255,7 @@ Madhu Challa challa@noironetworks.com > Manohar K C manukc@gmail.com > Marcin Mirecki mmirecki@redhat.com > Mario Cabrera mario.cabrera@hpe.com > -Mark D. Gray mark.d.gray@intel.com > +Mark D. Gray mark.d.gray@redhat.com > Mark Hamilton > Mark Kavanagh mark.b.kavanagh81@gmail.com > Mark Maglana mmaglana@gmail.com >
On 04/09/2020 14:23, Ilya Maximets wrote: > On 8/28/20 7:03 PM, Mark Gray wrote: >> Signed-off-by: Mark Gray <mark.d.gray@redhat.com> >> --- Posted a v5 and just saw this now :( Thanks for the feedback. > > Maybe you also want to update .mailmap? > So git will know your correct e-mail address. For 'git blame' purposes. :) I didn't know about mailmap so happy to do this. > > It also make sense to send this patch separately (not as part of a patch set) > and have a bit more meaningful patch subject, e.g. have your name in it (this > just simplifies automatic patch detection since there are already a bunch of > equally named patches in patchwork). Sure thing, I will redo in v6 > > And since we're here, it's usually better to have a cover letter while sending > patch-sets with more than one patch. > And, yes, as Flavio already mentioned, please, don't send new versions in reply > to old ones. Yeah, it was a weird one because it didn't have a cover letter initially as it was one patch. However, I can redo this in v6. > > Best regards, Ilya Maximets. > >> AUTHORS.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/AUTHORS.rst b/AUTHORS.rst >> index 4d8eaa3bd..cb26e0197 100644 >> --- a/AUTHORS.rst >> +++ b/AUTHORS.rst >> @@ -255,7 +255,7 @@ Madhu Challa challa@noironetworks.com >> Manohar K C manukc@gmail.com >> Marcin Mirecki mmirecki@redhat.com >> Mario Cabrera mario.cabrera@hpe.com >> -Mark D. Gray mark.d.gray@intel.com >> +Mark D. Gray mark.d.gray@redhat.com >> Mark Hamilton >> Mark Kavanagh mark.b.kavanagh81@gmail.com >> Mark Maglana mmaglana@gmail.com >> >
diff --git a/AUTHORS.rst b/AUTHORS.rst index 4d8eaa3bd..cb26e0197 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -255,7 +255,7 @@ Madhu Challa challa@noironetworks.com Manohar K C manukc@gmail.com Marcin Mirecki mmirecki@redhat.com Mario Cabrera mario.cabrera@hpe.com -Mark D. Gray mark.d.gray@intel.com +Mark D. Gray mark.d.gray@redhat.com Mark Hamilton Mark Kavanagh mark.b.kavanagh81@gmail.com Mark Maglana mmaglana@gmail.com
Signed-off-by: Mark Gray <mark.d.gray@redhat.com> --- AUTHORS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)