diff mbox series

[ovs-dev,04/11] netdev-offload-dpdk: Support partial TCP/UDP port matching

Message ID 20200518154026.18059-5-elibr@mellanox.com
State Changes Requested
Headers show
Series netdev datapath offload: Support IPv6 and VXLAN encap | expand

Commit Message

Eli Britstein May 18, 2020, 3:40 p.m. UTC 
The cited commit failed partial matching of TCP/UDP port matching,
preventing such offload of supporting HWs. Remove this failure.

Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Eli Britstein <elibr@mellanox.com>
Reviewed-by: Roni Bar Yanai <roniba@mellanox.com>
---
 lib/netdev-offload-dpdk.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Sriharsha Basavapatna May 20, 2020, 9:12 a.m. UTC | #1 
On Mon, May 18, 2020 at 9:10 PM Eli Britstein <elibr@mellanox.com> wrote:
>
> The cited commit failed partial matching of TCP/UDP port matching,
> preventing such offload of supporting HWs. Remove this failure.
>
> Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
> Signed-off-by: Eli Britstein <elibr@mellanox.com>
> Reviewed-by: Roni Bar Yanai <roniba@mellanox.com>
> ---
>  lib/netdev-offload-dpdk.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
> index 03b56f3b5..87627cc9b 100644
> --- a/lib/netdev-offload-dpdk.c
> +++ b/lib/netdev-offload-dpdk.c
> @@ -763,12 +763,6 @@ parse_flow_match(struct flow_patterns *patterns,
>          goto out;
>      }
>
> -    if ((match->wc.masks.tp_src && match->wc.masks.tp_src != OVS_BE16_MAX) ||
> -        (match->wc.masks.tp_dst && match->wc.masks.tp_dst != OVS_BE16_MAX)) {
> -        ret = -1;
> -        goto out;
> -    }
> -
>      if (proto == IPPROTO_TCP) {
>          struct rte_flow_item_tcp *spec, *mask;
>
> --
> 2.14.5
>

LGTM.
Thanks,
-Harsha
diff mbox series

Patch

diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 03b56f3b5..87627cc9b 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@@ -763,12 +763,6 @@  parse_flow_match(struct flow_patterns *patterns,
         goto out;
     }
 
-    if ((match->wc.masks.tp_src && match->wc.masks.tp_src != OVS_BE16_MAX) ||
-        (match->wc.masks.tp_dst && match->wc.masks.tp_dst != OVS_BE16_MAX)) {
-        ret = -1;
-        goto out;
-    }
-
     if (proto == IPPROTO_TCP) {
         struct rte_flow_item_tcp *spec, *mask;