From patchwork Mon May 18 08:06:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: aginwala aginwala X-Patchwork-Id: 1292388 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=J04vvTf9; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49QWpQ0xh7z9sT6 for ; Mon, 18 May 2020 18:07:40 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D14E286942; Mon, 18 May 2020 08:07:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jCcdCFdBe531; Mon, 18 May 2020 08:07:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 33ADF8616A; Mon, 18 May 2020 08:07:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1535EC0881; Mon, 18 May 2020 08:07:38 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7D623C07FF for ; Mon, 18 May 2020 08:07:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6C15387C7E for ; Mon, 18 May 2020 08:07:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u3S78yxovE5x for ; Mon, 18 May 2020 08:07:36 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by whitealder.osuosl.org (Postfix) with ESMTPS id C180587C74 for ; Mon, 18 May 2020 08:07:36 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id x2so4597027pfx.7 for ; Mon, 18 May 2020 01:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WZrqGNC7B9XcZBx6Sr1YRA9+fQcngXvXyD950HdFH6M=; b=J04vvTf9AyoJXJ9qMSC+d9nANiwQY0bAb0CNGQ5bWfsDufwUd9Xmfi7R2hQYvW228N WgENmXuWh1xOImFa8Z/Jtx1NWd14ooi3NA+cTzHmgvvhIE1ZObr6y7DpDyM+7yYprGon ZTu6D2kQJ+HL+94H9qvA1dtJHW8oPyvw1JX61YNQKr1EtlYNJa3hnZPMbMZk78jHgkjn bIHjvUTuMxeiMhia3jNg/Q/lnp/ozaR41uO/MWAjGdwE1i/RNLOXyJG62Og/nesBpJcM hpNJF5SyA9/MFb9czTvhmqF6ETuvpM7k5pGVjB/jchbPXmmm/nqqAvCAXkuvz2mzsUyi 6cNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WZrqGNC7B9XcZBx6Sr1YRA9+fQcngXvXyD950HdFH6M=; b=XlUCD9QqDChyZ4h5XRbs6AJlKHyHQ4Z4PnuHchMh4dMkHJSN4LWaRns8T8ejhu7nuA 8mr9SV+Z9iWnjGF4VydeSHlgYCfvtHAJ3w+eljiDcgBRd/bkU1R3qjldl4kCx8leWz9a YsfhL3kaIG/d0ESjIw3BeIA0Bn5sCna6l6U2Gep2CU2ibBRvwVGypgRiAA/W9uXtRP0E lvZwrXffwYMSLD56NmU2ILVUGyqHmjgYAg07ffxrcwhfvb4q1R+AAj3DtjeVuuL2PZro oiIIdva3tEWfoxNdlohOXTJXPuV8UC93b6WVjW84dtjb7mfSoLCoEtwCgSHZ3OBr/Ehr CGKw== X-Gm-Message-State: AOAM533PmZu3n/bFPWhSfYPSh10KboZAK/xJuXK3ArOoona+DJSMwVJt eoQ/s9zZdWjzad/H1iC9n+w+lLXb X-Google-Smtp-Source: ABdhPJzsdYIg8kzMG0Zd59geZQzIkAejdpHywGqGJ7OmboDb4twCzMD6HNXN2WkG0Myadq/XGVekww== X-Received: by 2002:a63:af02:: with SMTP id w2mr10741717pge.116.1589789256096; Mon, 18 May 2020 01:07:36 -0700 (PDT) Received: from LM-SJC-11020505.hsd1.ca.comcast.net. (c-71-198-142-45.hsd1.ca.comcast.net. [71.198.142.45]) by smtp.gmail.com with ESMTPSA id h137sm1987462pfe.146.2020.05.18.01.07.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2020 01:07:35 -0700 (PDT) From: amginwal@gmail.com To: dev@openvswitch.org Date: Mon, 18 May 2020 01:06:56 -0700 Message-Id: <20200518080656.23005-1-amginwal@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Cc: Aliasgar Ginwala Subject: [ovs-dev] [PATCH ovn v1] test/ovstest: fix shared library deps. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Aliasgar Ginwala When using --enable-shared for configure, make fails with error lib/.libs/libovn.so: undefined reference to `set_pidfile' collect2: error: ld returned 1 exit status Makefile:1616: recipe for target 'tests/ovstest' failed make[1]: *** [tests/ovstest] Error 1 make[1]: Leaving directory '/ovn' Makefile:1283: recipe for target 'all' failed make: *** [all] Error 2 Because commit 94cb7648d8c32246ac0bed61484e2e27332ed68c started using daemon.h for setting set_pidfile. Hence, need to link the same for ovstest to avoid failure. It also fixes current CI failing on master for: TESTSUITE=1 OPTS="--enable-shared" Signed-off-by: Aliasgar Ginwala --- tests/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/automake.mk b/tests/automake.mk index 3d39a8ac2..26b6d11b4 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -202,7 +202,8 @@ tests_ovstest_SOURCES = \ tests/ovstest.h \ tests/test-ovn.c -tests_ovstest_LDADD = $(OVS_LIBDIR)/libopenvswitch.la lib/libovn.la +tests_ovstest_LDADD = $(OVS_LIBDIR)/daemon.lo \ + $(OVS_LIBDIR)/libopenvswitch.la lib/libovn.la # Python tests. CHECK_PYFILES = \