diff mbox series

[ovs-dev,ovn] Fix typo for validation of logical ip in ipv6 mode.

Message ID 20200508071835.851174-1-numans@ovn.org
State Accepted
Headers show
Series [ovs-dev,ovn] Fix typo for validation of logical ip in ipv6 mode. | expand

Commit Message

Numan Siddique May 8, 2020, 7:18 a.m. UTC 
From: Artem Teleshev <artem.teleshev@gmail.com>

Reported-at: https://github.com/ovn-org/ovn/issues/42
Submitted-at: https://github.com/ovn-org/ovn/pull/43
Signed-off-by: Artem Teleshev <artem.teleshev@gmail.com>
Signed-off-by: Numan Siddique <numans@ovn.org>
---
 northd/ovn-northd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Numan Siddique May 8, 2020, 7:44 a.m. UTC | #1 
On Fri, May 8, 2020 at 12:49 PM <numans@ovn.org> wrote:

> From: Artem Teleshev <artem.teleshev@gmail.com>
>
> Reported-at: https://github.com/ovn-org/ovn/issues/42
> Submitted-at: https://github.com/ovn-org/ovn/pull/43
> Signed-off-by: Artem Teleshev <artem.teleshev@gmail.com>
> Signed-off-by: Numan Siddique <numans@ovn.org>
> ---
>

Thanks for the patch Artem. It was a good catch.
I applied this patch to master and branch-20.03.

Numan


>  northd/ovn-northd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> index 83e6134b0..76b4a14ee 100644
> --- a/northd/ovn-northd.c
> +++ b/northd/ovn-northd.c
> @@ -8845,7 +8845,7 @@ build_lrouter_flows(struct hmap *datapaths, struct
> hmap *ports,
>              /* Check the validity of nat->logical_ip. 'logical_ip' can
>               * be a subnet when the type is "snat". */
>              if (is_v6) {
> -                error = ipv6_parse_masked(nat->external_ip, &ipv6,
> &mask_v6);
> +                error = ipv6_parse_masked(nat->logical_ip, &ipv6,
> &mask_v6);
>              } else {
>                  error = ip_parse_masked(nat->logical_ip, &ip, &mask);
>              }
> --
> 2.26.2
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
diff mbox series

Patch

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 83e6134b0..76b4a14ee 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -8845,7 +8845,7 @@  build_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
             /* Check the validity of nat->logical_ip. 'logical_ip' can
              * be a subnet when the type is "snat". */
             if (is_v6) {
-                error = ipv6_parse_masked(nat->external_ip, &ipv6, &mask_v6);
+                error = ipv6_parse_masked(nat->logical_ip, &ipv6, &mask_v6);
             } else {
                 error = ip_parse_masked(nat->logical_ip, &ip, &mask);
             }