| Message ID | 20200203142222.11152-1-fbl@sysclose.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] netdev-linux-private: fix max length to be 16 bits | expand |
On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > The dp_packet length is limited to 16 bits, so document that > and fix the length value accordingly. > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") > Signed-off-by: Flavio Leitner <fbl@sysclose.org> Thanks! Applied to master.
On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > > The dp_packet length is limited to 16 bits, so document that > > and fix the length value accordingly. > > > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") > > Signed-off-by: Flavio Leitner <fbl@sysclose.org> > > Thanks! Applied to master. and branch-2.13
On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote: > On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > > > The dp_packet length is limited to 16 bits, so document that > > > and fix the length value accordingly. > > > > > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") > > > Signed-off-by: Flavio Leitner <fbl@sysclose.org> > > > > Thanks! Applied to master. > > and branch-2.13 Awesome! Thanks Ben. All these TSO related patches most probably should go to branch-2.13.
On Thu, Feb 06, 2020 at 04:54:25PM -0300, Flavio Leitner wrote: > On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote: > > On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > > > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > > > > The dp_packet length is limited to 16 bits, so document that > > > > and fix the length value accordingly. > > > > > > > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") > > > > Signed-off-by: Flavio Leitner <fbl@sysclose.org> > > > > > > Thanks! Applied to master. > > > > and branch-2.13 > > Awesome! Thanks Ben. > > All these TSO related patches most probably should go to branch-2.13. I'd appreciate a list of commits to backport, since I'm not following along that closely. Thanks, Ben.
On Thu, Feb 06, 2020 at 12:27:53PM -0800, Ben Pfaff wrote: > On Thu, Feb 06, 2020 at 04:54:25PM -0300, Flavio Leitner wrote: > > On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote: > > > On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > > > > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > > > > > The dp_packet length is limited to 16 bits, so document that > > > > > and fix the length value accordingly. > > > > > > > > > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") > > > > > Signed-off-by: Flavio Leitner <fbl@sysclose.org> > > > > > > > > Thanks! Applied to master. > > > > > > and branch-2.13 > > > > Awesome! Thanks Ben. > > > > All these TSO related patches most probably should go to branch-2.13. > > I'd appreciate a list of commits to backport, since I'm not following > along that closely. I just replied on the last one you asked if 2.13 is needed. Ilya merged David's patch and most probably will merge his follow up (has acks), so the TSO queue is empty now. I will hint in the next patches that it needs 2.13 as well.
On Thu, Feb 06, 2020 at 05:59:13PM -0300, Flavio Leitner wrote: > On Thu, Feb 06, 2020 at 12:27:53PM -0800, Ben Pfaff wrote: > > On Thu, Feb 06, 2020 at 04:54:25PM -0300, Flavio Leitner wrote: > > > On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote: > > > > On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > > > > > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > > > > > > The dp_packet length is limited to 16 bits, so document that > > > > > > and fix the length value accordingly. > > > > > > > > > > > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") > > > > > > Signed-off-by: Flavio Leitner <fbl@sysclose.org> > > > > > > > > > > Thanks! Applied to master. > > > > > > > > and branch-2.13 > > > > > > Awesome! Thanks Ben. > > > > > > All these TSO related patches most probably should go to branch-2.13. > > > > I'd appreciate a list of commits to backport, since I'm not following > > along that closely. > > I just replied on the last one you asked if 2.13 is needed. Ilya merged > David's patch ...and backported it to branch-2.13... > and most probably will merge his follow up (has acks), so the TSO > queue is empty now. > > I will hint in the next patches that it needs 2.13 as well. Great.
diff --git a/lib/netdev-linux-private.h b/lib/netdev-linux-private.h index 143616ca8..be2d7b10b 100644 --- a/lib/netdev-linux-private.h +++ b/lib/netdev-linux-private.h @@ -38,7 +38,8 @@ struct netdev; -#define LINUX_RXQ_TSO_MAX_LEN 65536 +/* The maximum packet length is 16 bits */ +#define LINUX_RXQ_TSO_MAX_LEN 65535 struct netdev_rxq_linux { struct netdev_rxq up;
The dp_packet length is limited to 16 bits, so document that and fix the length value accordingly. Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") Signed-off-by: Flavio Leitner <fbl@sysclose.org> --- lib/netdev-linux-private.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)