| Message ID | 20191125101144.28443-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] vswitch.xml: Replace non-ASCII characters. | expand |
On Mon, 25 Nov 2019 11:11:44 +0100 Ilya Maximets <i.maximets@ovn.org> wrote: > This fixes OSX build on Travis: > > ovs-vswitchd.conf.db.5:4061: warning: invalid input character code 128 > ovs-vswitchd.conf.db.5:4061: warning: invalid input character code 156 > > Fixes: aa453e319961 ("ofproto-dpif: Expose datapath ND Extensions > capability to ovsdb") Signed-off-by: Ilya Maximets > <i.maximets@ovn.org> --- > vswitchd/vswitch.xml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Do you think it would be useful if checkpatch.py catch that? Acked-by: Flavio Leitner <fbl@sysclose.org> > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index 09e7bdf5f..b311ef278 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -5830,7 +5830,7 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 > type=patch options:peer=p1 \ </column> > <column name="capabilities" key="nd_ext" type='{"type": > "boolean"}'> True if the datapath supports OVS_KEY_ATTR_ND_EXTENSIONS > to match on > - ICMPv6 "ND reserved" and “ND option type“ header fields. If > false, > + ICMPv6 "ND reserved" and "ND option type" header fields. If > false, the datapath reports error if the feature is used. > </column> > <group title="Clone Actions">
On 25.11.2019 13:51, Flavio Leitner wrote: > On Mon, 25 Nov 2019 11:11:44 +0100 > Ilya Maximets <i.maximets@ovn.org> wrote: > >> This fixes OSX build on Travis: >> >> ovs-vswitchd.conf.db.5:4061: warning: invalid input character code 128 >> ovs-vswitchd.conf.db.5:4061: warning: invalid input character code 156 >> >> Fixes: aa453e319961 ("ofproto-dpif: Expose datapath ND Extensions >> capability to ovsdb") Signed-off-by: Ilya Maximets >> <i.maximets@ovn.org> --- >> vswitchd/vswitch.xml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > Do you think it would be useful if checkpatch.py catch that? Yes, I thought about this. This is task that hard for humans, but very simple for a script. One thing is that I don't know to which files we should apply this 'ASCII-only' policy. For now it could be just for vswitch.xml as it's known to produce build issues. Do you want to make a patch? > > Acked-by: Flavio Leitner <fbl@sysclose.org> Thanks! Applied to master. Best regards, Ilya Maximets.
On Mon, 25 Nov 2019 15:08:44 +0100 Ilya Maximets <i.maximets@ovn.org> wrote: > On 25.11.2019 13:51, Flavio Leitner wrote: > > On Mon, 25 Nov 2019 11:11:44 +0100 > > Ilya Maximets <i.maximets@ovn.org> wrote: > > > >> This fixes OSX build on Travis: > >> > >> ovs-vswitchd.conf.db.5:4061: warning: invalid input character code > >> 128 ovs-vswitchd.conf.db.5:4061: warning: invalid input character > >> code 156 > >> > >> Fixes: aa453e319961 ("ofproto-dpif: Expose datapath ND Extensions > >> capability to ovsdb") Signed-off-by: Ilya Maximets > >> <i.maximets@ovn.org> --- > >> vswitchd/vswitch.xml | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Do you think it would be useful if checkpatch.py catch that? > > Yes, I thought about this. This is task that hard for humans, > but very simple for a script. One thing is that I don't know to > which files we should apply this 'ASCII-only' policy. For now > it could be just for vswitch.xml as it's known to produce build > issues. I don't know either, but that sounds like a good start. > Do you want to make a patch? Unfortunately not in the next couple weeks. If anyone doesn't get it until there, I can do it. fbl
On Mon, Nov 25, 2019 at 03:08:44PM +0100, Ilya Maximets wrote: > On 25.11.2019 13:51, Flavio Leitner wrote: > > On Mon, 25 Nov 2019 11:11:44 +0100 > > Ilya Maximets <i.maximets@ovn.org> wrote: > > > >> This fixes OSX build on Travis: > >> > >> ovs-vswitchd.conf.db.5:4061: warning: invalid input character code 128 > >> ovs-vswitchd.conf.db.5:4061: warning: invalid input character code 156 > >> > >> Fixes: aa453e319961 ("ofproto-dpif: Expose datapath ND Extensions > >> capability to ovsdb") Signed-off-by: Ilya Maximets > >> <i.maximets@ovn.org> --- > >> vswitchd/vswitch.xml | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Do you think it would be useful if checkpatch.py catch that? > > Yes, I thought about this. This is task that hard for humans, > but very simple for a script. One thing is that I don't know to > which files we should apply this 'ASCII-only' policy. For now > it could be just for vswitch.xml as it's known to produce build > issues. I think it would be reasonable to apply it to all *.xml files with the possible exception of ofproto/ipfix.xml.
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 09e7bdf5f..b311ef278 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -5830,7 +5830,7 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ </column> <column name="capabilities" key="nd_ext" type='{"type": "boolean"}'> True if the datapath supports OVS_KEY_ATTR_ND_EXTENSIONS to match on - ICMPv6 "ND reserved" and “ND option type“ header fields. If false, + ICMPv6 "ND reserved" and "ND option type" header fields. If false, the datapath reports error if the feature is used. </column> <group title="Clone Actions">
This fixes OSX build on Travis: ovs-vswitchd.conf.db.5:4061: warning: invalid input character code 128 ovs-vswitchd.conf.db.5:4061: warning: invalid input character code 156 Fixes: aa453e319961 ("ofproto-dpif: Expose datapath ND Extensions capability to ovsdb") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- vswitchd/vswitch.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)