diff mbox series

[ovs-dev,branch-2.10,1/2] Set release date for 2.10.2.

Message ID 20190221004715.18439-1-jpettit@ovn.org
State Accepted
Headers show
Series [ovs-dev,branch-2.10,1/2] Set release date for 2.10.2. | expand

Commit Message

Justin Pettit Feb. 21, 2019, 12:47 a.m. UTC 
Signed-off-by: Justin Pettit <jpettit@ovn.org>
---
 NEWS             | 3 ++-
 debian/changelog | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

0-day Robot Feb. 21, 2019, 12:57 a.m. UTC | #1 
Bleep bloop.  Greetings Justin Pettit, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


build:
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/conntrack-tcp.lo -MD -MP -MF lib/.deps/conntrack-tcp.Tpo -c lib/conntrack-tcp.c -o lib/conntrack-tcp.o
depbase=`echo lib/conntrack-other.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT lib/conntrack-other.lo -MD -MP -MF $depbase.Tpo -c -o lib/conntrack-other.lo lib/conntrack-other.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/conntrack-other.lo -MD -MP -MF lib/.deps/conntrack-other.Tpo -c lib/conntrack-other.c -o lib/conntrack-other.o
depbase=`echo lib/conntrack.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT lib/conntrack.lo -MD -MP -MF $depbase.Tpo -c -o lib/conntrack.lo lib/conntrack.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/conntrack.lo -MD -MP -MF lib/.deps/conntrack.Tpo -c lib/conntrack.c -o lib/conntrack.o
lib/conntrack.c: In function 'handle_ftp_ctl':
lib/conntrack.c:3164:18: error: 'addr_offset_from_ftp_data_start' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     modify_packet(pkt, ftp_data_start + addr_offset_from_ftp_data_start,
                  ^
lib/conntrack.c:3185:12: note: 'addr_offset_from_ftp_data_start' was declared here
     size_t addr_offset_from_ftp_data_start;
            ^
lib/conntrack.c: At top level:
cc1: error: unrecognized command line option "-Wno-null-pointer-arithmetic" [-Werror]
cc1: all warnings being treated as errors
make[2]: *** [lib/conntrack.lo] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole@bytheb.org

Thanks,
0-day Robot
Justin Pettit Feb. 21, 2019, 2:17 a.m. UTC | #2 
Hi, Darrell.  You've handled most of the userspace conntrack work lately.  Are you able to reproduce this issue?  My compiler build it without any problem.

Thanks,

--Justin


> Begin forwarded message:
> 
> From: 0-day Robot <robot@bytheb.org>
> Subject: Re: Set release date for 2.10.2.
> Date: February 20, 2019 at 5:57:54 PM MST
> To: Justin Pettit <jpettit@ovn.org>
> Cc: dev@openvswitch.org
> 
> Bleep bloop.  Greetings Justin Pettit, I am a robot and I have tried out your patch.
> Thanks for your contribution.
> 
> I encountered some error that I wasn't expecting.  See the details below.
> 
> 
> build:
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/conntrack-tcp.lo -MD -MP -MF lib/.deps/conntrack-tcp.Tpo -c lib/conntrack-tcp.c -o lib/conntrack-tcp.o
> depbase=`echo lib/conntrack-other.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT lib/conntrack-other.lo -MD -MP -MF $depbase.Tpo -c -o lib/conntrack-other.lo lib/conntrack-other.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/conntrack-other.lo -MD -MP -MF lib/.deps/conntrack-other.Tpo -c lib/conntrack-other.c -o lib/conntrack-other.o
> depbase=`echo lib/conntrack.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT lib/conntrack.lo -MD -MP -MF $depbase.Tpo -c -o lib/conntrack.lo lib/conntrack.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/conntrack.lo -MD -MP -MF lib/.deps/conntrack.Tpo -c lib/conntrack.c -o lib/conntrack.o
> lib/conntrack.c: In function 'handle_ftp_ctl':
> lib/conntrack.c:3164:18: error: 'addr_offset_from_ftp_data_start' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>     modify_packet(pkt, ftp_data_start + addr_offset_from_ftp_data_start,
>                  ^
> lib/conntrack.c:3185:12: note: 'addr_offset_from_ftp_data_start' was declared here
>     size_t addr_offset_from_ftp_data_start;
>            ^
> lib/conntrack.c: At top level:
> cc1: error: unrecognized command line option "-Wno-null-pointer-arithmetic" [-Werror]
> cc1: all warnings being treated as errors
> make[2]: *** [lib/conntrack.lo] Error 1
> make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make: *** [all] Error 2
> 
> 
> Please check this out.  If you feel there has been an error, please email aconole@bytheb.org
> 
> Thanks,
> 0-day Robot
Darrell Ball Feb. 21, 2019, 3:44 a.m. UTC | #3 
I was able to see it with the address sanitizer as a false positive

You can backport

faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d

as far back as 2.8

On Wed, Feb 20, 2019 at 6:17 PM Justin Pettit <jpettit@ovn.org> wrote:

> Hi, Darrell.  You've handled most of the userspace conntrack work lately.
> Are you able to reproduce this issue?  My compiler build it without any
> problem.
>
> Thanks,
>
> --Justin
>
>
> Begin forwarded message:
>
> *From: *0-day Robot <robot@bytheb.org>
> *Subject: **Re: Set release date for 2.10.2.*
> *Date: *February 20, 2019 at 5:57:54 PM MST
> *To: *Justin Pettit <jpettit@ovn.org>
> *Cc: *dev@openvswitch.org
>
> Bleep bloop.  Greetings Justin Pettit, I am a robot and I have tried out
> your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting.  See the details below.
>
>
> build:
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror
> -g -O2 -MT lib/conntrack-tcp.lo -MD -MP -MF lib/.deps/conntrack-tcp.Tpo -c
> lib/conntrack-tcp.c -o lib/conntrack-tcp.o
> depbase=`echo lib/conntrack-other.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99
> -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib
>    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
> -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT
> lib/conntrack-other.lo -MD -MP -MF $depbase.Tpo -c -o
> lib/conntrack-other.lo lib/conntrack-other.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror
> -g -O2 -MT lib/conntrack-other.lo -MD -MP -MF lib/.deps/conntrack-other.Tpo
> -c lib/conntrack-other.c -o lib/conntrack-other.o
> depbase=`echo lib/conntrack.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99
> -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib
>    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
> -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT
> lib/conntrack.lo -MD -MP -MF $depbase.Tpo -c -o lib/conntrack.lo
> lib/conntrack.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror
> -g -O2 -MT lib/conntrack.lo -MD -MP -MF lib/.deps/conntrack.Tpo -c
> lib/conntrack.c -o lib/conntrack.o
> lib/conntrack.c: In function 'handle_ftp_ctl':
> lib/conntrack.c:3164:18: error: 'addr_offset_from_ftp_data_start' may be
> used uninitialized in this function [-Werror=maybe-uninitialized]
>     modify_packet(pkt, ftp_data_start + addr_offset_from_ftp_data_start,
>                  ^
> lib/conntrack.c:3185:12: note: 'addr_offset_from_ftp_data_start' was
> declared here
>     size_t addr_offset_from_ftp_data_start;
>            ^
> lib/conntrack.c: At top level:
> cc1: error: unrecognized command line option
> "-Wno-null-pointer-arithmetic" [-Werror]
> cc1: all warnings being treated as errors
> make[2]: *** [lib/conntrack.lo] Error 1
> make[2]: Leaving directory
> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory
> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make: *** [all] Error 2
>
>
> Please check this out.  If you feel there has been an error, please email
> aconole@bytheb.org <aconole@bytheb.org>
>
> Thanks,
> 0-day Robot
>
>
>
Darrell Ball Feb. 21, 2019, 5:13 a.m. UTC | #4 
On Wed, Feb 20, 2019 at 7:44 PM Darrell Ball <dlu998@gmail.com> wrote:

> I was able to see it with the address sanitizer as a false positive
>
> You can backport
>
> faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d
>
> as far back as 2.8
>

hmm, after rebase, I can see this pretty consistently with '-O2' with
various gcc versions
without -O2, I do not see it.

anyways pls backport faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d
as far back as 2.8; 2.8 might need a minor adjustment,



>
> On Wed, Feb 20, 2019 at 6:17 PM Justin Pettit <jpettit@ovn.org> wrote:
>
>> Hi, Darrell.  You've handled most of the userspace conntrack work
>> lately.  Are you able to reproduce this issue?  My compiler build it
>> without any problem.
>>
>> Thanks,
>>
>> --Justin
>>
>>
>> Begin forwarded message:
>>
>> *From: *0-day Robot <robot@bytheb.org>
>> *Subject: **Re: Set release date for 2.10.2.*
>> *Date: *February 20, 2019 at 5:57:54 PM MST
>> *To: *Justin Pettit <jpettit@ovn.org>
>> *Cc: *dev@openvswitch.org
>>
>> Bleep bloop.  Greetings Justin Pettit, I am a robot and I have tried out
>> your patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting.  See the details below.
>>
>>
>> build:
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
>> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
>> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror
>> -g -O2 -MT lib/conntrack-tcp.lo -MD -MP -MF lib/.deps/conntrack-tcp.Tpo -c
>> lib/conntrack-tcp.c -o lib/conntrack-tcp.o
>> depbase=`echo lib/conntrack-other.lo | sed
>> 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99
>> -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib
>>    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
>> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
>> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
>> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
>> -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT
>> lib/conntrack-other.lo -MD -MP -MF $depbase.Tpo -c -o
>> lib/conntrack-other.lo lib/conntrack-other.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
>> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
>> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror
>> -g -O2 -MT lib/conntrack-other.lo -MD -MP -MF lib/.deps/conntrack-other.Tpo
>> -c lib/conntrack-other.c -o lib/conntrack-other.o
>> depbase=`echo lib/conntrack.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99
>> -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib
>>    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
>> -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
>> -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
>> -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
>> -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT
>> lib/conntrack.lo -MD -MP -MF $depbase.Tpo -c -o lib/conntrack.lo
>> lib/conntrack.c &&\
>> mv -f $depbase.Tpo $depbase.Plo
>> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I
>> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra
>> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum
>> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes
>> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers
>> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror
>> -g -O2 -MT lib/conntrack.lo -MD -MP -MF lib/.deps/conntrack.Tpo -c
>> lib/conntrack.c -o lib/conntrack.o
>> lib/conntrack.c: In function 'handle_ftp_ctl':
>> lib/conntrack.c:3164:18: error: 'addr_offset_from_ftp_data_start' may be
>> used uninitialized in this function [-Werror=maybe-uninitialized]
>>     modify_packet(pkt, ftp_data_start + addr_offset_from_ftp_data_start,
>>                  ^
>> lib/conntrack.c:3185:12: note: 'addr_offset_from_ftp_data_start' was
>> declared here
>>     size_t addr_offset_from_ftp_data_start;
>>            ^
>> lib/conntrack.c: At top level:
>> cc1: error: unrecognized command line option
>> "-Wno-null-pointer-arithmetic" [-Werror]
>> cc1: all warnings being treated as errors
>> make[2]: *** [lib/conntrack.lo] Error 1
>> make[2]: Leaving directory
>> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
>> make[1]: *** [all-recursive] Error 1
>> make[1]: Leaving directory
>> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
>> make: *** [all] Error 2
>>
>>
>> Please check this out.  If you feel there has been an error, please email
>> aconole@bytheb.org <aconole@bytheb.org>
>>
>> Thanks,
>> 0-day Robot
>>
>>
>>
Justin Pettit Feb. 21, 2019, 5:29 a.m. UTC | #5 
> On Feb 20, 2019, at 10:13 PM, Darrell Ball <dlu998@gmail.com> wrote:
> 
> 
> On Wed, Feb 20, 2019 at 7:44 PM Darrell Ball <dlu998@gmail.com> wrote:
> I was able to see it with the address sanitizer as a false positive
> 
> You can backport
> 
> faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d
> 
> as far back as 2.8
> 
> hmm, after rebase, I can see this pretty consistently with '-O2' with various gcc versions
> without -O2, I do not see it.
> 
> anyways pls backport faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d
> as far back as 2.8; 2.8 might need a minor adjustment,

Thanks.  It looks like it needed to be backported to 2.10 and 2.8 only.  I did that and pushed the changes to their respective branches.

--Justin
Aaron Conole Feb. 21, 2019, 7:12 p.m. UTC | #6 
Justin Pettit <jpettit@ovn.org> writes:

>> On Feb 20, 2019, at 10:13 PM, Darrell Ball <dlu998@gmail.com> wrote:
>> 
>> 
>> On Wed, Feb 20, 2019 at 7:44 PM Darrell Ball <dlu998@gmail.com> wrote:
>> I was able to see it with the address sanitizer as a false positive
>> 
>> You can backport
>> 
>> faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d
>> 
>> as far back as 2.8
>> 
>> hmm, after rebase, I can see this pretty consistently with '-O2' with various gcc versions
>> without -O2, I do not see it.

For future information, higher optimization levels will allow the
flow-path analysis to expose additional warnings.  Without higher
optimization levels, some of the code flow isn't analyzed.

If anyone thinks it's worthwhile, I can make another robot job that will
rebuild the various branches and mail the list on a weekly cadence.

>> anyways pls backport faa0826dd9fca6a57293d1a74a6f838cdd0c5b3d
>> as far back as 2.8; 2.8 might need a minor adjustment,
>
> Thanks.  It looks like it needed to be backported to 2.10 and 2.8
> only.  I did that and pushed the changes to their respective branches.
>
> --Justin
>
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff Feb. 21, 2019, 8:30 p.m. UTC | #7 
On Thu, Feb 21, 2019 at 02:12:40PM -0500, Aaron Conole wrote:
> If anyone thinks it's worthwhile, I can make another robot job that will
> rebuild the various branches and mail the list on a weekly cadence.

I like that idea!
Flavio Leitner Feb. 22, 2019, 8:26 p.m. UTC | #8 
On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpettit@ovn.org>
> ---

Your patches are okay, but unfortunately while testing I found an
issue which is resolved by the commit below in branch-2.11 and master:

commit 024d93f62ca7a7fef9c8fc5f69a38b60ebf7e0ab
Author: Ben Pfaff <blp@ovn.org>
Date:   Wed Nov 14 16:07:30 2018 -0800

    ofp-actions: Make all actions a multiple of OFPACT_ALIGNTO bytes.


Otherwise the ovs-testcontroller segfaults:

1275: bridge - add port after stopping controller     FAILED
(bridge.at:99)

#0  0x00007faa27ea553f in raise () from /lib64/libc.so.6
#1  0x00007faa27e8f895 in abort () from /lib64/libc.so.6
#2  0x000000000044cfab in ofputil_protocol_to_ofp_version (protocol=(unknown: 0)) at lib/ofp-protocol.c:123
#3  0x000000000043152f in ofputil_encode_flow_mod (fm=0x7ffc00eae900, protocol=(unknown: 0)) at lib/ofp-flow.c:370
#4  0x0000000000409bf9 in lswitch_handshake (sw=0x1226680) at lib/learning-switch.c:219

Notice that protocol is zeroed. It happens when ofpact_init() is called.

branch-2.9 seems to have the bug as well but the test doesn't reproduce the
issue.

fbl
Ben Pfaff Feb. 27, 2019, 5:31 p.m. UTC | #9 
On Fri, Feb 22, 2019 at 05:26:30PM -0300, Flavio Leitner wrote:
> On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote:
> > Signed-off-by: Justin Pettit <jpettit@ovn.org>
> > ---
> 
> Your patches are okay, but unfortunately while testing I found an
> issue which is resolved by the commit below in branch-2.11 and master:
> 
> commit 024d93f62ca7a7fef9c8fc5f69a38b60ebf7e0ab
> Author: Ben Pfaff <blp@ovn.org>
> Date:   Wed Nov 14 16:07:30 2018 -0800
> 
>     ofp-actions: Make all actions a multiple of OFPACT_ALIGNTO bytes.
> 
> 
> Otherwise the ovs-testcontroller segfaults:
> 
> 1275: bridge - add port after stopping controller     FAILED
> (bridge.at:99)

Oops.

I backported this patch to branch-2.10 and branch-2.9 now.  Thanks.
Flavio Leitner Feb. 27, 2019, 7:24 p.m. UTC | #10 
On Wed, Feb 27, 2019 at 09:31:27AM -0800, Ben Pfaff wrote:
> On Fri, Feb 22, 2019 at 05:26:30PM -0300, Flavio Leitner wrote:
> > On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote:
> > > Signed-off-by: Justin Pettit <jpettit@ovn.org>
> > > ---
> > 
> > Your patches are okay, but unfortunately while testing I found an
> > issue which is resolved by the commit below in branch-2.11 and master:
> > 
> > commit 024d93f62ca7a7fef9c8fc5f69a38b60ebf7e0ab
> > Author: Ben Pfaff <blp@ovn.org>
> > Date:   Wed Nov 14 16:07:30 2018 -0800
> > 
> >     ofp-actions: Make all actions a multiple of OFPACT_ALIGNTO bytes.
> > 
> > 
> > Otherwise the ovs-testcontroller segfaults:
> > 
> > 1275: bridge - add port after stopping controller     FAILED
> > (bridge.at:99)
> 
> Oops.
> 
> I backported this patch to branch-2.10 and branch-2.9 now.  Thanks.

It works now, thanks Ben!
fbl
diff mbox series

Patch

diff --git a/NEWS b/NEWS
index 35aafc037398..e1ea8278016b 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@ 
-v2.10.2 - xx xxx xxxx
+v2.10.2 - 20 Feb 2019
 --------------------
+   - Bug fixes
 
 v2.10.1 - 19 Oct 2018
 --------------------
diff --git a/debian/changelog b/debian/changelog
index 23cd3870e4cc..f77c4d7e4670 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,7 +2,7 @@  openvswitch (2.10.2-1) unstable; urgency=low
    [ Open vSwitch team ]
    * New upstream version
 
- -- Open vSwitch team <dev@openvswitch.org>  Fri, 19 Oct 2018 15:58:23 -0700
+ -- Open vSwitch team <dev@openvswitch.org>  Wed, 20 Feb 2019 16:35:35 -0800
 
 openvswitch (2.10.1-1) unstable; urgency=low
    [ Open vSwitch team ]