diff mbox series

[ovs-dev] ovsdb-idl: Fix recently introduced Python 3 tests.

Message ID 20180818221147.17639-1-blp@ovn.org
State Accepted
Headers show
Series [ovs-dev] ovsdb-idl: Fix recently introduced Python 3 tests. | expand

Commit Message

Ben Pfaff Aug. 18, 2018, 10:11 p.m. UTC
CC: Numan Siddique <nusiddiq@redhat.com>
Fixes: c1aa16d191d2 ("ovs python: ovs.stream.open_block() returns success even if the remote is unreachable")
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/351311.html
Reported-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 tests/ovsdb-idl.at | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Justin Pettit Aug. 18, 2018, 11:20 p.m. UTC | #1
> On Aug 18, 2018, at 3:11 PM, Ben Pfaff <blp@ovn.org> wrote:
> 
> CC: Numan Siddique <nusiddiq@redhat.com>
> Fixes: c1aa16d191d2 ("ovs python: ovs.stream.open_block() returns success even if the remote is unreachable")
> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/351311.html
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Ben Pfaff <blp@ovn.org>

Acked-by: Justin Pettit <jpettit@ovn.org>

--Justin
Ben Pfaff Aug. 18, 2018, 11:59 p.m. UTC | #2
On Sat, Aug 18, 2018 at 04:20:42PM -0700, Justin Pettit wrote:
> 
> 
> > On Aug 18, 2018, at 3:11 PM, Ben Pfaff <blp@ovn.org> wrote:
> > 
> > CC: Numan Siddique <nusiddiq@redhat.com>
> > Fixes: c1aa16d191d2 ("ovs python: ovs.stream.open_block() returns success even if the remote is unreachable")
> > Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/351311.html
> > Reported-by: Simon Horman <simon.horman@netronome.com>
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> 
> Acked-by: Justin Pettit <jpettit@ovn.org>

Thanks, applied and backported.
diff mbox series

Patch

diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at
index e9b4161f0396..142eee794f28 100644
--- a/tests/ovsdb-idl.at
+++ b/tests/ovsdb-idl.at
@@ -1798,5 +1798,5 @@  m4_define([CHECK_STREAM_OPEN_BLOCK_PY],
    AT_CHECK([$3 $srcdir/test-stream.py tcp:127.0.0.1:$TCP_PORT], [1], [ignore])
    AT_CLEANUP])
 
-CHECK_STREAM_OPEN_BLOCK_PY([Check PY2 Stream open block], [$HAVE_PYTHON], [$PYTHON])
-CHECK_STREAM_OPEN_BLOCK_PY([Check PY3 Stream open block], [$HAVE_PYTHON], [$PYTHON3])
+CHECK_STREAM_OPEN_BLOCK_PY([Check PY2 Stream open block], [$HAVE_PYTHON2], [$PYTHON2])
+CHECK_STREAM_OPEN_BLOCK_PY([Check PY3 Stream open block], [$HAVE_PYTHON3], [$PYTHON3])