Message ID | 20180702105019.10345-19-jkbs@redhat.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41K44s2H2kz9s29 for <incoming@patchwork.ozlabs.org>; Mon, 2 Jul 2018 20:59:09 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id DA1C0D14; Mon, 2 Jul 2018 10:51:04 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 250DED15 for <dev@openvswitch.org>; Mon, 2 Jul 2018 10:51:04 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B2100334 for <dev@openvswitch.org>; Mon, 2 Jul 2018 10:51:03 +0000 (UTC) Received: by mail-wr0-f195.google.com with SMTP id q10-v6so324679wrd.4 for <dev@openvswitch.org>; Mon, 02 Jul 2018 03:51:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=oSRFp1j3rpRryBObQ9u5PVwZMR95oTIvX9Dv753gx1M=; b=Opeh7ZPat9WA0xgbsVpaUZjNMxJcu7exTQ3zY3Vy9rK080+cKpkbkH0tsfyIHO8AeX CMZlr/pv1NU5ocATqEPCSt0wttAJhIAJTnkDHQnXazBYz7UBiHvEE2jNwRnTVhv/l4Aw 6MVhSkxI7cLFxg+IaQSX+FsZv2BqZkBn9jIbPqMGCAcoqglFqR5lk4ZC1EPNuxCrr5vc jQ4KTo4WU02FaCKBkPb1LcDZFnFL9/V+t+YldMKLD2kiWowAkEYtRnL2wHonj4MN486R zL2xzFjwrIlv0pr7FEDMkRW0DsKkGdPY4BIJXAxwmab6KrJxl3OFqB3aQqnnKdsbns7+ CwAw== X-Gm-Message-State: APt69E1roTeqQ0UHA3Uxvq7b7LhBLHNW7Mlxz5UdMBnlvvytWlfCadId rcu14Uooa7aayG27dQ9zPKhWoxIPZmQ= X-Google-Smtp-Source: AAOMgpcN91zqsy3nr7XhIG8d0HWQmmNIPRczaXXlIzBMiSJQyJpQMnLUWlFjRsjmkCJDcxaqAjrPhQ== X-Received: by 2002:adf:b05c:: with SMTP id g28-v6mr19038756wra.128.1530528662134; Mon, 02 Jul 2018 03:51:02 -0700 (PDT) Received: from redhat.com (218.red-2-136-166.dynamicip.rima-tde.net. [2.136.166.218]) by smtp.gmail.com with ESMTPSA id r14-v6sm22449543wrl.4.2018.07.02.03.51.01 for <dev@openvswitch.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jul 2018 03:51:01 -0700 (PDT) From: Jakub Sitnicki <jkbs@redhat.com> To: dev@openvswitch.org Date: Mon, 2 Jul 2018 12:50:14 +0200 Message-Id: <20180702105019.10345-19-jkbs@redhat.com> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20180702105019.10345-1-jkbs@redhat.com> References: <20180702105019.10345-1-jkbs@redhat.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 18/23] db-ctl-base: Fix resource deallocation on error path in cmd_find(). X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org |
Series |
Don't use ctl_fatal() in command handlers from db-ctl-base
|
expand
|
diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 5f386cab5..d3ca4ca70 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -1285,6 +1285,7 @@ cmd_find(struct ctl_context *ctx) ctx->error = check_condition(table, row, ctx->argv[i], ctx->symtab, &satisfied); if (ctx->error) { + free(columns); return; } if (!satisfied) {
Release resources now that we are returning to the caller on error. Signed-off-by: Jakub Sitnicki <jkbs@redhat.com> --- lib/db-ctl-base.c | 1 + 1 file changed, 1 insertion(+)