From patchwork Fri Apr 13 17:26:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 898031 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40N4TT1SdYz9s0t for ; Sat, 14 Apr 2018 03:27:09 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id BD534D88; Fri, 13 Apr 2018 17:27:07 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E4FDDD88 for ; Fri, 13 Apr 2018 17:27:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 46662673 for ; Fri, 13 Apr 2018 17:27:02 +0000 (UTC) X-Originating-IP: 208.91.3.26 Received: from sigabrt.benpfaff.org (unknown [208.91.3.26]) (Authenticated sender: blp@ovn.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 47A10240009; Fri, 13 Apr 2018 19:26:59 +0200 (CEST) From: Ben Pfaff To: dev@openvswitch.org Date: Fri, 13 Apr 2018 10:26:45 -0700 Message-Id: <20180413172655.31638-1-blp@ovn.org> X-Mailer: git-send-email 2.16.1 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ben Pfaff Subject: [ovs-dev] [PATCH 01/11] socket-util: Fix error in comment on ss_format_address(). X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The output for this function is a dynamic string and doesn't have a fixed buffer size, so the comment was wrong. Signed-off-by: Ben Pfaff Acked-by: Mark Michelson --- lib/socket-util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index 7fbcdf19feac..5485e3b515dd 100644 --- a/lib/socket-util.c +++ b/lib/socket-util.c @@ -995,8 +995,7 @@ is_safe_name(const char *name) } /* Formats the IPv4 or IPv6 address in 'ss' into 's'. If 'ss' is an IPv6 - * address, puts square brackets around the address. 'bufsize' should be at - * least SS_NTOP_BUFSIZE. */ + * address, puts square brackets around the address. */ void ss_format_address(const struct sockaddr_storage *ss, struct ds *s) {