| Message ID | 20180327172949.4808-1-aserdean@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] Windows: Fix broken build caused by a bad file extension | expand |
On Tue, Mar 27, 2018 at 08:29:49PM +0300, Alin Gabriel Serdean wrote: > The compiler (cl) complains: > `ovsdb/ovsdb-server.c(689) : fatal error C1083: > Cannot open include file: 'ovsdb/_server.ovsschema.inc': > No such file or directory` > (https://ci.appveyor.com/project/blp/ovs/build/1.0.4079#L2586) > > Generated compiler objects have the extension `.obj` on Windows. > > This patch switches to `$(OBJEXT)` instead, so the schema will be generated. > > Signed-off-by: Alin Gabriel Serdean aserdean@ovn.org Oops! Thanks for the fix. Acked-by: Ben Pfaff <blp@ovn.org>
> -----Mesaj original----- > De la: ovs-dev-bounces@openvswitch.org <ovs-dev- > bounces@openvswitch.org> În numele Ben Pfaff > Trimis: Saturday, March 31, 2018 10:47 PM > Către: Alin Gabriel Serdean <aserdean@ovn.org> > Cc: ovs-dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] Windows: Fix broken build caused by a bad > file extension > > On Tue, Mar 27, 2018 at 08:29:49PM +0300, Alin Gabriel Serdean wrote: > > The compiler (cl) complains: > > `ovsdb/ovsdb-server.c(689) : fatal error C1083: > > Cannot open include file: 'ovsdb/_server.ovsschema.inc': > > No such file or directory` > > (https://ci.appveyor.com/project/blp/ovs/build/1.0.4079#L2586) > > > > Generated compiler objects have the extension `.obj` on Windows. > > > > This patch switches to `$(OBJEXT)` instead, so the schema will be > generated. > > > > Signed-off-by: Alin Gabriel Serdean aserdean@ovn.org > > Oops! Thanks for the fix. > > Acked-by: Ben Pfaff <blp@ovn.org> No worries, it happens. Thanks for the review, I applied it on master! Alin.
diff --git a/ovsdb/automake.mk b/ovsdb/automake.mk index c43acf7e4..b895f4292 100644 --- a/ovsdb/automake.mk +++ b/ovsdb/automake.mk @@ -120,7 +120,7 @@ OVSDB_DOT = $(run_python) $(srcdir)/ovsdb/ovsdb-dot.in EXTRA_DIST += ovsdb/_server.ovsschema CLEANFILES += ovsdb/_server.ovsschema.inc -ovsdb/ovsdb-server.o: ovsdb/_server.ovsschema.inc +ovsdb/ovsdb-server.$(OBJEXT): ovsdb/_server.ovsschema.inc ovsdb/_server.ovsschema.inc: ovsdb/_server.ovsschema $(srcdir)/build-aux/text2c $(AM_V_GEN)$(run_python) $(srcdir)/build-aux/text2c < $< > $@.tmp $(AM_V_at)mv $@.tmp $@
The compiler (cl) complains: `ovsdb/ovsdb-server.c(689) : fatal error C1083: Cannot open include file: 'ovsdb/_server.ovsschema.inc': No such file or directory` (https://ci.appveyor.com/project/blp/ovs/build/1.0.4079#L2586) Generated compiler objects have the extension `.obj` on Windows. This patch switches to `$(OBJEXT)` instead, so the schema will be generated. Signed-off-by: Alin Gabriel Serdean aserdean@ovn.org --- ovsdb/automake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)