diff mbox series

[ovs-dev,1/4] windows: _set_output_format is no longer required from VS2015

Message ID 20171101171907.14588-2-aserdean@ovn.org
State Accepted
Headers show
Series windows: Add support for compiling using 2015/2017 | expand

Commit Message

Alin-Gabriel Serdean Nov. 1, 2017, 5:19 p.m. UTC
_set_output_format is deprecated ang no longer required
starting from MSC_VER 1900 (VS 2015):
https://msdn.microsoft.com/en-us/library/bb531344(v=vs.140).aspx .

Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
---
 lib/util.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ben Pfaff Nov. 3, 2017, 6:35 p.m. UTC | #1
On Wed, Nov 01, 2017 at 07:19:04PM +0200, Alin Gabriel Serdean wrote:
> _set_output_format is deprecated ang no longer required
> starting from MSC_VER 1900 (VS 2015):
> https://msdn.microsoft.com/en-us/library/bb531344(v=vs.140).aspx .
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>

Acked-by: Ben Pfaff <blp@ovn.org>
Anand Kumar Nov. 8, 2017, 1:16 a.m. UTC | #2
Acked-by: Anand Kumar <kumaranand@vmware.com> 

Thanks,
Anand Kumar

On 11/1/17, 10:19 AM, "ovs-dev-bounces@openvswitch.org on behalf of Alin Gabriel Serdean" <ovs-dev-bounces@openvswitch.org on behalf of aserdean@ovn.org> wrote:

    _set_output_format is deprecated ang no longer required
    starting from MSC_VER 1900 (VS 2015):
    https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.microsoft.com_en-2Dus_library_bb531344-28v-3Dvs.140-29.aspx&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=yEgaXlwe41sP3LbGMAubII4irfoybfVX2pjCZM4zFaU&s=gy1kgdZ7venpTYdBQqn2cDkljkBhYcZE08tjs_ga91Y&e= .
    
    Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
    ---
     lib/util.c | 3 +++
     1 file changed, 3 insertions(+)
    
    diff --git a/lib/util.c b/lib/util.c
    index a26cd51..9e6edd2 100644
    --- a/lib/util.c
    +++ b/lib/util.c
    @@ -490,7 +490,10 @@ ovs_set_program_name(const char *argv0, const char *version)
         size_t max_len = strlen(argv0) + 1;
     
         SetErrorMode(GetErrorMode() | SEM_NOGPFAULTERRORBOX);
    +#if _MSC_VER < 1900
    +     /* This function is deprecated from 1900 (Visual Studio 2015) */
         _set_output_format(_TWO_DIGIT_EXPONENT);
    +#endif
     
         basename = xmalloc(max_len);
         _splitpath_s(argv0, NULL, 0, NULL, 0, basename, max_len, NULL, 0);
    -- 
    2.10.2.windows.1
    
    _______________________________________________
    dev mailing list
    dev@openvswitch.org
    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=yEgaXlwe41sP3LbGMAubII4irfoybfVX2pjCZM4zFaU&s=87SRdgxShRv85dWPSuVnDd0TzXdqbuSmPd9KDzSejdo&e=
diff mbox series

Patch

diff --git a/lib/util.c b/lib/util.c
index a26cd51..9e6edd2 100644
--- a/lib/util.c
+++ b/lib/util.c
@@ -490,7 +490,10 @@  ovs_set_program_name(const char *argv0, const char *version)
     size_t max_len = strlen(argv0) + 1;
 
     SetErrorMode(GetErrorMode() | SEM_NOGPFAULTERRORBOX);
+#if _MSC_VER < 1900
+     /* This function is deprecated from 1900 (Visual Studio 2015) */
     _set_output_format(_TWO_DIGIT_EXPONENT);
+#endif
 
     basename = xmalloc(max_len);
     _splitpath_s(argv0, NULL, 0, NULL, 0, basename, max_len, NULL, 0);