| Message ID | 20170621232519.557-1-joe@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Jun 21, 2017 at 04:25:19PM -0700, Joe Stringer wrote: > Commit b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") > broke distclean, as it doesn't clean up the generated python scripts > after building. Fix by adding the new script files to CLEANFILES. > > Fixes: b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") > Signed-off-by: Joe Stringer <joe@ovn.org> > --- > CC: Timothy Redaelli <tredaelli@redhat.com> Looks correct. I didn't test it, but if you did then: Acked-by: Ben Pfaff <blp@ovn.org>
On 21 June 2017 at 17:04, Ben Pfaff <blp@ovn.org> wrote: > On Wed, Jun 21, 2017 at 04:25:19PM -0700, Joe Stringer wrote: >> Commit b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") >> broke distclean, as it doesn't clean up the generated python scripts >> after building. Fix by adding the new script files to CLEANFILES. >> >> Fixes: b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") >> Signed-off-by: Joe Stringer <joe@ovn.org> >> --- >> CC: Timothy Redaelli <tredaelli@redhat.com> > > Looks correct. I didn't test it, but if you did then: > Acked-by: Ben Pfaff <blp@ovn.org> Thanks, I tested it and applied to master.
diff --git a/ovn/utilities/automake.mk b/ovn/utilities/automake.mk index 69ff0c37be3e..e8c59a2ebd1c 100644 --- a/ovn/utilities/automake.mk +++ b/ovn/utilities/automake.mk @@ -31,6 +31,8 @@ EXTRA_DIST += \ CLEANFILES += \ ovn/utilities/ovn-ctl.8 \ + ovn/utilities/ovn-docker-overlay-driver \ + ovn/utilities/ovn-docker-underlay-driver \ ovn/utilities/ovn-nbctl.8 \ ovn/utilities/ovn-sbctl.8 \ ovn/utilities/ovn-trace.8 \ diff --git a/vtep/automake.mk b/vtep/automake.mk index bd419cd331b7..069e1906c565 100644 --- a/vtep/automake.mk +++ b/vtep/automake.mk @@ -41,6 +41,7 @@ scripts_SCRIPTS += \ vtep/ovs-vtep EXTRA_DIST += vtep/ovs-vtep.in +CLEANFILES += vtep/ovs-vtep FLAKE8_PYFILES += vtep/ovs-vtep
Commit b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") broke distclean, as it doesn't clean up the generated python scripts after building. Fix by adding the new script files to CLEANFILES. Fixes: b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") Signed-off-by: Joe Stringer <joe@ovn.org> --- CC: Timothy Redaelli <tredaelli@redhat.com> --- ovn/utilities/automake.mk | 2 ++ vtep/automake.mk | 1 + 2 files changed, 3 insertions(+)