| Message ID | 20170620194434.2920-1-aserdean@cloudbasesolutions.com |
|---|---|
| State | Accepted |
| Headers | show |
Acked-by: Sairam Venugopal <vsairam@vmware.com> On 6/20/17, 12:44 PM, "ovs-dev-bounces@openvswitch.org on behalf of Alin Serdean" <ovs-dev-bounces@openvswitch.org on behalf of aserdean@cloudbasesolutions.com> wrote: >x->errline is a signed int >(https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_blob_934386dd129a3f15b2546562a775f2f43dd3aac6_tests_test-2Dsflow.c-23L88&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=52CvYQ6uQ_8gMUb3CO0zBOQi3EAEo7U12sf_jRaLMto&s=jGs1qklVubrW1fOsUpNILtvW2UjkxaFlMmcyjv1eM1o&e= ) >Flagged by static code analysis. > >Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> >--- > tests/test-sflow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tests/test-sflow.c b/tests/test-sflow.c >index 6125d38..039a1b1 100644 >--- a/tests/test-sflow.c >+++ b/tests/test-sflow.c >@@ -675,7 +675,7 @@ print_sflow(struct ofpbuf *buf) > process_datagram(x); > } else { > // CATCH >- printf("\n>>>>> ERROR in " __FILE__ " at line %u\n", x->errline); >+ printf("\n>>>>> ERROR in " __FILE__ " at line %d\n", x->errline); > } > } > >-- >2.10.2.windows.1 >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=52CvYQ6uQ_8gMUb3CO0zBOQi3EAEo7U12sf_jRaLMto&s=rOqbBbyjEA6AKF-RlAt-BrQ1BrGinru0mkM-FdoOoks&e=
On 20 June 2017 at 12:44, Alin Serdean <aserdean@cloudbasesolutions.com> wrote: > x->errline is a signed int > (https://github.com/openvswitch/ovs/blob/934386dd129a3f15b2546562a775f2 > f43dd3aac6/tests/test-sflow.c#L88) > Flagged by static code analysis. > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > Applied, thanks! > --- > tests/test-sflow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/test-sflow.c b/tests/test-sflow.c > index 6125d38..039a1b1 100644 > --- a/tests/test-sflow.c > +++ b/tests/test-sflow.c > @@ -675,7 +675,7 @@ print_sflow(struct ofpbuf *buf) > process_datagram(x); > } else { > // CATCH > - printf("\n>>>>> ERROR in " __FILE__ " at line %u\n", x->errline); > + printf("\n>>>>> ERROR in " __FILE__ " at line %d\n", x->errline); > } > } > > -- > 2.10.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/tests/test-sflow.c b/tests/test-sflow.c index 6125d38..039a1b1 100644 --- a/tests/test-sflow.c +++ b/tests/test-sflow.c @@ -675,7 +675,7 @@ print_sflow(struct ofpbuf *buf) process_datagram(x); } else { // CATCH - printf("\n>>>>> ERROR in " __FILE__ " at line %u\n", x->errline); + printf("\n>>>>> ERROR in " __FILE__ " at line %d\n", x->errline); } }
x->errline is a signed int (https://github.com/openvswitch/ovs/blob/934386dd129a3f15b2546562a775f2f43dd3aac6/tests/test-sflow.c#L88) Flagged by static code analysis. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> --- tests/test-sflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)