diff mbox

[ovs-dev,v1,2/6] packets: Fix the reset dp_packet buffer issue in packet_put_ra_prefix_opt

Message ID 20170615083815.8458-1-nusiddiq@redhat.com
State Accepted
Headers show

Commit Message

Numan Siddique June 15, 2017, 8:38 a.m. UTC 
From: Numan Siddique <nusiddiq@redhat.com>

packet_put_ra_prefix_opt() resets the dp_packet buffer incorrectly.

Fixes: b24ab67c2dfd ("packets: add compose_nd_ra")
Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
---
 lib/packets.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ben Pfaff July 10, 2017, 8:46 p.m. UTC | #1 
On Thu, Jun 15, 2017 at 02:08:15PM +0530, nusiddiq@redhat.com wrote:
> From: Numan Siddique <nusiddiq@redhat.com>
> 
> packet_put_ra_prefix_opt() resets the dp_packet buffer incorrectly.
> 
> Fixes: b24ab67c2dfd ("packets: add compose_nd_ra")
> Signed-off-by: Numan Siddique <nusiddiq@redhat.com>

Thanks, I applied this to master.  (It doesn't appear to be on older
branches.)
diff mbox

Patch

diff --git a/lib/packets.c b/lib/packets.c
index d51c91a..7a9071c 100644
--- a/lib/packets.c
+++ b/lib/packets.c
@@ -1536,7 +1536,8 @@  packet_put_ra_prefix_opt(struct dp_packet *b,
     nh->ip6_plen = htons(prev_l4_size + ND_PREFIX_OPT_LEN);
 
     struct ovs_ra_msg *ra = dp_packet_l4(b);
-    struct ovs_nd_prefix_opt *prefix_opt = dp_packet_put_uninit(b, sizeof *b);
+    struct ovs_nd_prefix_opt *prefix_opt =
+        dp_packet_put_uninit(b, sizeof *prefix_opt);
     prefix_opt->type = ND_OPT_PREFIX_INFORMATION;
     prefix_opt->len = 4;
     prefix_opt->prefix_len = plen;