diff mbox

[ovs-dev] checkpatch: Also exempt Makefile.am from leading whitespace checks.

Message ID 20170601143624.3940-1-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff June 1, 2017, 2:36 p.m. UTC
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 utilities/checkpatch.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gregory Rose June 1, 2017, 5:10 p.m. UTC | #1
On Thu, 2017-06-01 at 07:36 -0700, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
>  utilities/checkpatch.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> index 1c83b2965cbd..3ebd53ad06b7 100755
> --- a/utilities/checkpatch.py
> +++ b/utilities/checkpatch.py
> @@ -200,7 +200,7 @@ checks = [
>       'check': lambda x: line_length_check(x),
>       'print': lambda: print_warning("Line length is >79-characters long")},
>  
> -    {'regex': '$(?<!\.mk)',
> +    {'regex': '$(?<!\.mk|\.am)',
>       'match_name': None,
>       'check': lambda x: not leading_whitespace_is_spaces(x),
>       'print': lambda: print_warning("Line has non-spaces leading whitespace")},

LGTM

Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Ben Pfaff June 1, 2017, 10:29 p.m. UTC | #2
On Thu, Jun 01, 2017 at 10:10:02AM -0700, Greg Rose wrote:
> On Thu, 2017-06-01 at 07:36 -0700, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> > ---
> >  utilities/checkpatch.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> > index 1c83b2965cbd..3ebd53ad06b7 100755
> > --- a/utilities/checkpatch.py
> > +++ b/utilities/checkpatch.py
> > @@ -200,7 +200,7 @@ checks = [
> >       'check': lambda x: line_length_check(x),
> >       'print': lambda: print_warning("Line length is >79-characters long")},
> >  
> > -    {'regex': '$(?<!\.mk)',
> > +    {'regex': '$(?<!\.mk|\.am)',
> >       'match_name': None,
> >       'check': lambda x: not leading_whitespace_is_spaces(x),
> >       'print': lambda: print_warning("Line has non-spaces leading whitespace")},
> 
> LGTM
> 
> Reviewed-by: Greg Rose <gvrose8192@gmail.com>

Thanks, applied to master.
diff mbox

Patch

diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 1c83b2965cbd..3ebd53ad06b7 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -200,7 +200,7 @@  checks = [
      'check': lambda x: line_length_check(x),
      'print': lambda: print_warning("Line length is >79-characters long")},
 
-    {'regex': '$(?<!\.mk)',
+    {'regex': '$(?<!\.mk|\.am)',
      'match_name': None,
      'check': lambda x: not leading_whitespace_is_spaces(x),
      'print': lambda: print_warning("Line has non-spaces leading whitespace")},