From patchwork Tue May 23 17:59:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alin Serdean X-Patchwork-Id: 766153 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wXNc61Jgmz9sP4 for ; Wed, 24 May 2017 04:00:38 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 08E75BC0; Tue, 23 May 2017 17:59:15 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 1566EBA9 for ; Tue, 23 May 2017 17:59:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.cloudbasesolutions.com (mail.cloudbasesolutions.com [91.232.152.5]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 29287244 for ; Tue, 23 May 2017 17:59:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.cloudbasesolutions.com (Postfix) with ESMTP id 64857428D7 for ; Tue, 23 May 2017 20:59:09 +0300 (EEST) X-Virus-Scanned: amavisd-new at cloudbasesolutions.com Received: from mail.cloudbasesolutions.com ([127.0.0.1]) by localhost (mail.cloudbasesolutions.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jCLGko64GioV for ; Tue, 23 May 2017 20:59:08 +0300 (EEST) Received: from mail.cloudbasesolutions.com (unknown [10.77.78.3]) by mail.cloudbasesolutions.com (Postfix) with ESMTP id 4538A428D6 for ; Tue, 23 May 2017 20:59:08 +0300 (EEST) Received: from CBSEX1.cloudbase.local ([10.77.78.3]) by CBSEX1.cloudbase.local ([10.77.78.3]) with mapi id 14.03.0319.002; Tue, 23 May 2017 19:59:08 +0200 From: Alin Serdean To: "dev@openvswitch.org" Thread-Topic: [PATCH 2/3] datapath-windows: add two new build targets for code analysis Thread-Index: AQHS0+5FTRfIdsuvqEamyaD9FeqlMQ== Date: Tue, 23 May 2017 17:59:07 +0000 Message-ID: <20170523175858.524-2-aserdean@cloudbasesolutions.com> References: <20170523175858.524-1-aserdean@cloudbasesolutions.com> In-Reply-To: <20170523175858.524-1-aserdean@cloudbasesolutions.com> Accept-Language: en-US, it-IT Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.77.78.1] MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 2/3] datapath-windows: add two new build targets for code analysis X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Add two new build targets: 'Win8Analyze' and 'Win8.1Analyze'. The new build targets have the static code analyzer (built in Visual Studio feature). This patch also introduces a new make target ('datapath_windows_analyze') this can be added to the CI jobs to get a list warnings/errors issued by the code analyzer. Signed-off-by: Alin Gabriel Serdean Acked-by: Anand Kumar --- datapath-windows/Package/package.VcxProj | 28 ++++++++++++ datapath-windows/Package/package.VcxProj.user | 6 +++ datapath-windows/automake.mk | 4 ++ datapath-windows/ovsext.sln | 14 ++++++ datapath-windows/ovsext/ovsext.vcxproj | 62 +++++++++++++++++++++++++++ datapath-windows/ovsext/ovsext.vcxproj.user | 6 +++ 6 files changed, 120 insertions(+) diff --git a/datapath-windows/Package/package.VcxProj b/datapath-windows/Package/package.VcxProj index 24bb914..4d6db59 100644 --- a/datapath-windows/Package/package.VcxProj +++ b/datapath-windows/Package/package.VcxProj @@ -25,6 +25,14 @@ Win8 Release x64 + + Win8.1Analyze + x64 + + + Win8Analyze + x64 + Utility @@ -46,6 +54,11 @@ true WindowsKernelModeDriver8.1 + + WindowsV6.3 + true + WindowsKernelModeDriver8.1 + @@ -58,6 +71,11 @@ true WindowsKernelModeDriver8.1 + + Windows8 + true + WindowsKernelModeDriver8.1 + @@ -105,6 +123,11 @@ true + + + true + + true @@ -115,6 +138,11 @@ true + + + true + + true diff --git a/datapath-windows/Package/package.VcxProj.user b/datapath-windows/Package/package.VcxProj.user index 75ea9d7..6231d93 100644 --- a/datapath-windows/Package/package.VcxProj.user +++ b/datapath-windows/Package/package.VcxProj.user @@ -3,9 +3,15 @@ TestSign + + TestSign + TestSign + + TestSign + TestSign diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk index 4f7b55a..49011f1 100644 --- a/datapath-windows/automake.mk +++ b/datapath-windows/automake.mk @@ -82,3 +82,7 @@ EXTRA_DIST += \ datapath-windows/ovsext/precomp.h \ datapath-windows/ovsext/precompsrc.c \ datapath-windows/ovsext/resource.h + +datapath_windows_analyze: all + MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1Analyze" + MSBuild.exe //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8Analyze" diff --git a/datapath-windows/ovsext.sln b/datapath-windows/ovsext.sln index 6cf441b..1000104 100644 --- a/datapath-windows/ovsext.sln +++ b/datapath-windows/ovsext.sln @@ -14,8 +14,10 @@ Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Win10Debug|x64 = Win10Debug|x64 Win10Release|x64 = Win10Release|x64 + Win8.1Analyze|x64 = Win8.1Analyze|x64 Win8.1Debug|x64 = Win8.1Debug|x64 Win8.1Release|x64 = Win8.1Release|x64 + Win8Analyze|x64 = Win8Analyze|x64 Win8Debug|x64 = Win8Debug|x64 Win8Release|x64 = Win8Release|x64 EndGlobalSection @@ -26,10 +28,16 @@ Global {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.ActiveCfg = Win10 Release|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.Build.0 = Win10 Release|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win10Release|x64.Deploy.0 = Win10 Release|x64 + {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.ActiveCfg = Win8.1Analyze|x64 + {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.Build.0 = Win8.1Analyze|x64 + {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Analyze|x64.Deploy.0 = Win8.1Analyze|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Debug|x64.ActiveCfg = Win8.1 Debug|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Debug|x64.Build.0 = Win8.1 Debug|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Release|x64.ActiveCfg = Win8.1 Release|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8.1Release|x64.Build.0 = Win8.1 Release|x64 + {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Analyze|x64.ActiveCfg = Win8Analyze|x64 + {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Analyze|x64.Build.0 = Win8Analyze|x64 + {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Analyze|x64.Deploy.0 = Win8Analyze|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Debug|x64.ActiveCfg = Win8 Debug|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Debug|x64.Build.0 = Win8 Debug|x64 {911D7389-3E61-449F-B8F3-14AD7EE9A0F2}.Win8Release|x64.ActiveCfg = Win8 Release|x64 @@ -40,12 +48,18 @@ Global {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win10Release|x64.ActiveCfg = Win10 Release|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win10Release|x64.Build.0 = Win10 Release|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win10Release|x64.Deploy.0 = Win10 Release|x64 + {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Analyze|x64.ActiveCfg = Win8.1Analyze|x64 + {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Analyze|x64.Build.0 = Win8.1Analyze|x64 + {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Analyze|x64.Deploy.0 = Win8.1Analyze|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Debug|x64.ActiveCfg = Win8.1 Debug|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Debug|x64.Build.0 = Win8.1 Debug|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Debug|x64.Deploy.0 = Win8.1 Debug|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Release|x64.ActiveCfg = Win8.1 Release|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Release|x64.Build.0 = Win8.1 Release|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8.1Release|x64.Deploy.0 = Win8.1 Release|x64 + {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8Analyze|x64.ActiveCfg = Win8Analyze|x64 + {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8Analyze|x64.Build.0 = Win8Analyze|x64 + {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8Analyze|x64.Deploy.0 = Win8Analyze|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8Debug|x64.ActiveCfg = Win8 Debug|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8Debug|x64.Build.0 = Win8 Debug|x64 {63FE215D-98BE-4440-8081-C6160EFB80FA}.Win8Debug|x64.Deploy.0 = Win8 Debug|x64 diff --git a/datapath-windows/ovsext/ovsext.vcxproj b/datapath-windows/ovsext/ovsext.vcxproj index cccf066..15a045e 100644 --- a/datapath-windows/ovsext/ovsext.vcxproj +++ b/datapath-windows/ovsext/ovsext.vcxproj @@ -25,6 +25,14 @@ Win8 Release x64 + + Win8.1Analyze + x64 + + + Win8Analyze + x64 + WDM @@ -46,6 +54,11 @@ True WindowsKernelModeDriver8.1 + + WindowsV6.3 + True + WindowsKernelModeDriver8.1 + @@ -58,6 +71,11 @@ True WindowsKernelModeDriver8.1 + + Win8 + True + WindowsKernelModeDriver8.1 + WindowsV6.3 False @@ -91,9 +109,15 @@ + + + + + + @@ -147,6 +171,12 @@ true + + true + + + true + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1 @@ -191,6 +221,17 @@ %(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1 + + + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1 + + + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1 + + + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1 + + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1 @@ -202,6 +243,17 @@ %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1 + + + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1 + + + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1 + + + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1 + + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1 @@ -223,23 +275,31 @@ $(IntDir);%(AdditionalIncludeDirectories);..\.. + $(IntDir);%(AdditionalIncludeDirectories);..\.. $(IntDir);%(AdditionalIncludeDirectories);..\.. + $(IntDir);%(AdditionalIncludeDirectories);..\.. $(IntDir);%(AdditionalIncludeDirectories);..\.. $(IntDir);%(AdditionalIncludeDirectories);..\.. $(IntDir);%(AdditionalIncludeDirectories);..\.. $(IntDir);%(AdditionalIncludeDirectories);..\.. true true + true true + true true true true + true + true $(Version) + $(Version) $(Version) + $(Version) $(Version) @@ -297,8 +357,10 @@ %(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1;VersionWithDots=$(Version);VersionWithCommas=$(Version.Replace('.',',')) %(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1;VersionWithDots=$(Version);VersionWithCommas=$(Version.Replace('.',',')) + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS630=1;VersionWithDots=$(Version);VersionWithCommas=$(Version.Replace('.',',')) %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1;VersionWithDots=$(Version);VersionWithCommas=$(Version.Replace('.',',')) %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1;VersionWithDots=$(Version);VersionWithCommas=$(Version.Replace('.',',')) + %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1;VersionWithDots=$(Version);VersionWithCommas=$(Version.Replace('.',',')) %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1;VersionWithDots=$(Version);VersionWithCommas=$(Version.Replace('.',',')) %(PreprocessorDefinitions);NDIS_WDM=1;NDIS640=1;VersionWithDots=$(Version);VersionWithCommas=$(Version.Replace('.',',')) diff --git a/datapath-windows/ovsext/ovsext.vcxproj.user b/datapath-windows/ovsext/ovsext.vcxproj.user index 75ea9d7..6231d93 100644 --- a/datapath-windows/ovsext/ovsext.vcxproj.user +++ b/datapath-windows/ovsext/ovsext.vcxproj.user @@ -3,9 +3,15 @@ TestSign + + TestSign + TestSign + + TestSign + TestSign