From patchwork Tue May 23 17:59:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alin Serdean X-Patchwork-Id: 766148 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wXNZV5RDWz9sP4 for ; Wed, 24 May 2017 03:59:14 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id BEC12B92; Tue, 23 May 2017 17:59:11 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6A398B8F for ; Tue, 23 May 2017 17:59:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.cloudbasesolutions.com (mail.cloudbasesolutions.com [91.232.152.5]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 8420E1F3 for ; Tue, 23 May 2017 17:59:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.cloudbasesolutions.com (Postfix) with ESMTP id 97349428D9 for ; Tue, 23 May 2017 20:59:08 +0300 (EEST) X-Virus-Scanned: amavisd-new at cloudbasesolutions.com Received: from mail.cloudbasesolutions.com ([127.0.0.1]) by localhost (mail.cloudbasesolutions.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sn9WO-hXVCZg for ; Tue, 23 May 2017 20:59:08 +0300 (EEST) Received: from mail.cloudbasesolutions.com (unknown [10.77.78.3]) by mail.cloudbasesolutions.com (Postfix) with ESMTP id 3BB13428D1 for ; Tue, 23 May 2017 20:59:08 +0300 (EEST) Received: from CBSEX1.cloudbase.local ([10.77.78.3]) by CBSEX1.cloudbase.local ([10.77.78.3]) with mapi id 14.03.0319.002; Tue, 23 May 2017 19:59:08 +0200 From: Alin Serdean To: "dev@openvswitch.org" Thread-Topic: [PATCH 1/3] datapath-windows: Remove Strsafe usage from datapath Thread-Index: AQHS0+5FbaNfQ9+EiEiABye6yjxECQ== Date: Tue, 23 May 2017 17:59:06 +0000 Message-ID: <20170523175858.524-1-aserdean@cloudbasesolutions.com> Accept-Language: en-US, it-IT Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.77.78.1] MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 1/3] datapath-windows: Remove Strsafe usage from datapath X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The removal is mandatory to use the VStudio 2013 static code analyzer. The only function that was used from the include is: 'StringCbLengthA'. We were not checking the result of that function, nor will the 'vportGet->name' exceed the 'OVS_MAX_PORT_NAME_LENGTH' limitation. Signed-off-by: Alin Gabriel Serdean Acked-By: Anand Kumar --- datapath-windows/ovsext/Netlink/NetlinkBuf.c | 1 - datapath-windows/ovsext/Vport.c | 2 -- datapath-windows/ovsext/precomp.h | 1 - 3 files changed, 4 deletions(-) diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c b/datapath-windows/ovsext/Netlink/NetlinkBuf.c index 0177e88..639b6e5 100644 --- a/datapath-windows/ovsext/Netlink/NetlinkBuf.c +++ b/datapath-windows/ovsext/Netlink/NetlinkBuf.c @@ -40,7 +40,6 @@ #include #include #include -#include #ifdef OVS_DBG_MOD #undef OVS_DBG_MOD diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index 9142937..075f419 100644 --- a/datapath-windows/ovsext/Vport.c +++ b/datapath-windows/ovsext/Vport.c @@ -1618,7 +1618,6 @@ OvsGetExtInfoIoctl(POVS_VPORT_GET vportGet, POVS_VPORT_EXT_INFO extInfo) { POVS_VPORT_ENTRY vport; - size_t len; LOCK_STATE_EX lockState; NTSTATUS status = STATUS_SUCCESS; BOOLEAN doConvert = FALSE; @@ -1626,7 +1625,6 @@ OvsGetExtInfoIoctl(POVS_VPORT_GET vportGet, RtlZeroMemory(extInfo, sizeof (POVS_VPORT_EXT_INFO)); NdisAcquireRWLockRead(gOvsSwitchContext->dispatchLock, &lockState, 0); if (vportGet->portNo == 0) { - StringCbLengthA(vportGet->name, OVS_MAX_PORT_NAME_LENGTH - 1, &len); vport = OvsFindVportByHvNameA(gOvsSwitchContext, vportGet->name); if (vport == NULL) { /* If the port is not a Hyper-V port and it has been added earlier, diff --git a/datapath-windows/ovsext/precomp.h b/datapath-windows/ovsext/precomp.h index a152582..14f6843 100644 --- a/datapath-windows/ovsext/precomp.h +++ b/datapath-windows/ovsext/precomp.h @@ -19,7 +19,6 @@ #include #include #include -#include #include "Types.h"