diff mbox

[ovs-dev,v3,3/3] build-windows: cccl fail compilation on Wimplicit-function-declaration

Message ID 20170522115636.12812-3-aserdean@cloudbasesolutions.com
State Accepted
Headers show

Commit Message

Alin Serdean May 22, 2017, 11:56 a.m. UTC 
From: Alin Serdean <aserdean@cloudbasesolutions.com>

Gcc compiler argument -Wall contains -Wimplicit-function-declaration which
gives warnings when a function is used before declared.
Map VStudio compiler error C4013 to it.
More info on C4013:
https://msdn.microsoft.com/en-us/library/d3ct4kz9.aspx

At the moment we cannot switch to the equivalent -Werror because we need
to solve other warnings.

As a temporary solution issue an error when this warning is triggered.
This will help development on the Windows side.

Suggested-by: Ben Pfaff <blp@ovn.org>
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
---
v3: no change
v2: no change
---
 build-aux/cccl | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Ben Pfaff May 25, 2017, 9:34 p.m. UTC | #1 
On Mon, May 22, 2017 at 11:56:50AM +0000, Alin Serdean wrote:
> From: Alin Serdean <aserdean@cloudbasesolutions.com>
> 
> Gcc compiler argument -Wall contains -Wimplicit-function-declaration which
> gives warnings when a function is used before declared.
> Map VStudio compiler error C4013 to it.
> More info on C4013:
> https://msdn.microsoft.com/en-us/library/d3ct4kz9.aspx
> 
> At the moment we cannot switch to the equivalent -Werror because we need
> to solve other warnings.
> 
> As a temporary solution issue an error when this warning is triggered.
> This will help development on the Windows side.
> 
> Suggested-by: Ben Pfaff <blp@ovn.org>
> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
> ---
> v3: no change
> v2: no change

Thanks Alin!  I applied all of these patches to master, without change.
diff mbox

Patch

diff --git a/build-aux/cccl b/build-aux/cccl
index 93f9c50..e2426fb 100644
--- a/build-aux/cccl
+++ b/build-aux/cccl
@@ -144,6 +144,14 @@  EOF
         #ignore pedantic
         ;;
 
+    -Wall)
+        # not all warnings are implemented
+        # the following is equivalent to
+        # Wimplicit-function-declaration but we will issue a compiler
+        # error
+        clopt="$clopt ${slash}we4013"
+        ;;
+
     -W*)
         #ignore warnings
         ;;