| Message ID | 20170518202055.28762-1-blp@ovn.org |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, 2017-05-18 at 13:20 -0700, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > ofproto/ofproto-dpif-xlate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index b308f21de100..39fed7e0b303 100644 > --- a/ofproto/ofproto-dpif-xlate.c > +++ b/ofproto/ofproto-dpif-xlate.c > @@ -4623,7 +4623,7 @@ xlate_output_trunc_action(struct xlate_ctx *ctx, > if (xport == NULL || xport->odp_port == ODPP_NONE) { > /* Since truncate happens at its following output action, if > * the output port is a patch port, the behavior is somehow > - * unpredicable. For simpilicity, disallow this case. */ > + * unpredictable. For simplicity, disallow this case. */ > ofputil_port_to_string(port, name, sizeof name); > xlate_report_error(ctx, "output_trunc does not support " > "patch port %s", name); 'unpredicable' isn't a word but maybe it should be... LGTM Acked-by: Greg Rose <gvrose8192@gmail.com>
On Thu, May 18, 2017 at 02:52:57PM -0700, Greg Rose wrote: > On Thu, 2017-05-18 at 13:20 -0700, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > ofproto/ofproto-dpif-xlate.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > > index b308f21de100..39fed7e0b303 100644 > > --- a/ofproto/ofproto-dpif-xlate.c > > +++ b/ofproto/ofproto-dpif-xlate.c > > @@ -4623,7 +4623,7 @@ xlate_output_trunc_action(struct xlate_ctx *ctx, > > if (xport == NULL || xport->odp_port == ODPP_NONE) { > > /* Since truncate happens at its following output action, if > > * the output port is a patch port, the behavior is somehow > > - * unpredicable. For simpilicity, disallow this case. */ > > + * unpredictable. For simplicity, disallow this case. */ > > ofputil_port_to_string(port, name, sizeof name); > > xlate_report_error(ctx, "output_trunc does not support " > > "patch port %s", name); > > 'unpredicable' isn't a word but maybe it should be... > > LGTM > > Acked-by: Greg Rose <gvrose8192@gmail.com> Thanks!
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index b308f21de100..39fed7e0b303 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -4623,7 +4623,7 @@ xlate_output_trunc_action(struct xlate_ctx *ctx, if (xport == NULL || xport->odp_port == ODPP_NONE) { /* Since truncate happens at its following output action, if * the output port is a patch port, the behavior is somehow - * unpredicable. For simpilicity, disallow this case. */ + * unpredictable. For simplicity, disallow this case. */ ofputil_port_to_string(port, name, sizeof name); xlate_report_error(ctx, "output_trunc does not support " "patch port %s", name);
Signed-off-by: Ben Pfaff <blp@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)