| Message ID | 20170424160645.2927-1-blp@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
Acked-by: Jarno Rajahalme <jarno@ovn.org> > On Apr 24, 2017, at 9:06 AM, Ben Pfaff <blp@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <blp@ovn.org> > --- > utilities/ovs-ofctl.8.in | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in > index 96232a5003e4..2e6679ebe98c 100644 > --- a/utilities/ovs-ofctl.8.in > +++ b/utilities/ovs-ofctl.8.in > @@ -1960,10 +1960,12 @@ other commands. The following keywords designated the allowed types: > .IP \fBall\fR > Execute all buckets in the group. > .IP \fBselect\fR > -Execute one bucket in the group. > -The switch should select the bucket in such a way that should implement > -equal load sharing is achieved. The switch may optionally select the > -bucket based on bucket weights. > +Execute one bucket in the group, balancing across the buckets > +according to their weights. To select a bucket, for each live bucket, > +Open vSwitch hashes flow data with the bucket ID and multiplies by the > +bucket weight to obtain a ``score,'' and then selects the bucket with > +the highest score. Use \fBselection_method\fR to control the flow > +data used for selection. > .IP \fBindirect\fR > Executes the one bucket in the group. > .IP \fBff\fR > -- > 2.10.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks! I applied this to master. On Mon, Apr 24, 2017 at 12:52:33PM -0700, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme <jarno@ovn.org> > > > On Apr 24, 2017, at 9:06 AM, Ben Pfaff <blp@ovn.org> wrote: > > > > Signed-off-by: Ben Pfaff <blp@ovn.org> > > --- > > utilities/ovs-ofctl.8.in | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in > > index 96232a5003e4..2e6679ebe98c 100644 > > --- a/utilities/ovs-ofctl.8.in > > +++ b/utilities/ovs-ofctl.8.in > > @@ -1960,10 +1960,12 @@ other commands. The following keywords designated the allowed types: > > .IP \fBall\fR > > Execute all buckets in the group. > > .IP \fBselect\fR > > -Execute one bucket in the group. > > -The switch should select the bucket in such a way that should implement > > -equal load sharing is achieved. The switch may optionally select the > > -bucket based on bucket weights. > > +Execute one bucket in the group, balancing across the buckets > > +according to their weights. To select a bucket, for each live bucket, > > +Open vSwitch hashes flow data with the bucket ID and multiplies by the > > +bucket weight to obtain a ``score,'' and then selects the bucket with > > +the highest score. Use \fBselection_method\fR to control the flow > > +data used for selection. > > .IP \fBindirect\fR > > Executes the one bucket in the group. > > .IP \fBff\fR > > -- > > 2.10.2 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index 96232a5003e4..2e6679ebe98c 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@ -1960,10 +1960,12 @@ other commands. The following keywords designated the allowed types: .IP \fBall\fR Execute all buckets in the group. .IP \fBselect\fR -Execute one bucket in the group. -The switch should select the bucket in such a way that should implement -equal load sharing is achieved. The switch may optionally select the -bucket based on bucket weights. +Execute one bucket in the group, balancing across the buckets +according to their weights. To select a bucket, for each live bucket, +Open vSwitch hashes flow data with the bucket ID and multiplies by the +bucket weight to obtain a ``score,'' and then selects the bucket with +the highest score. Use \fBselection_method\fR to control the flow +data used for selection. .IP \fBindirect\fR Executes the one bucket in the group. .IP \fBff\fR
Signed-off-by: Ben Pfaff <blp@ovn.org> --- utilities/ovs-ofctl.8.in | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)