diff mbox

[ovs-dev,RFC,2/6] port_group: add documentation entry

Message ID 20170403094100.28739-3-matthias.may@neratec.com
State RFC
Headers show

Commit Message

Matthias May April 3, 2017, 9:40 a.m. UTC
Signed-off-by: Matthias May <matthias.may@neratec.com>
---
 vswitchd/vswitch.xml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Ben Pfaff April 22, 2017, 1:50 a.m. UTC | #1
On Mon, Apr 03, 2017 at 11:40:56AM +0200, Matthias May wrote:
> Signed-off-by: Matthias May <matthias.may@neratec.com>

Thanks for adding the documentation.  I'd like to encourage you to add
some more background that explains in what circumstances this feature is
useful, perhaps based on the description in part 0.

This documentation says that "Valid values are 1-65279, 65534." but the
constraint on the column would prevent the value 65534 from being used.

(Also, it's not necessary to describe such a constraint by hand in the
documentation because the documentation generator will automatically
describe it.)

Thanks,

Ben.
diff mbox

Patch

diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 14297bf9a..3a7324f5d 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -1280,6 +1280,13 @@ 
       bonded Port.
     </column>
 
+    <column name="port_group">
+      The group affiliation of a port. If not set this defaults to the
+      open flow port number. Valid values are 1-65279, 65534.
+      Traffic processed by the normal action will not egress on a port which
+      has the same port_group as the port on which the frame ingressed.
+    </column>
+
     <group title="VLAN Configuration">
       <p>
         In short, a VLAN (short for ``virtual LAN'') is a way to partition a