| Message ID | 20170308143145.6188-1-aserdean@cloudbasesolutions.com |
|---|---|
| State | Accepted |
| Headers | show |
LGTM. Thanks. Thanks. Nick > On Mar 8, 2017, at 10:31 PM, Alin Serdean <aserdean@cloudbasesolutions.com> wrote: > > On slow systems(or which start processes slow) the test: > `testing mcast - delete the port mdb when port destroyed` > is influenced by the running time. > i.e.: http://64.119.130.115/ovs/911b7e9b08b9f4f890eeecd228d5124f4ce94d4e/testsuite.dir/2326/testsuite.log.gz <http://64.119.130.115/ovs/911b7e9b08b9f4f890eeecd228d5124f4ce94d4e/testsuite.dir/2326/testsuite.log.gz> > > This patches adds a time stop on vswitchd. > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com <mailto:aserdean@cloudbasesolutions.com>> > --- > tests/mcast-snooping.at <http://mcast-snooping.at/> | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/mcast-snooping.at <http://mcast-snooping.at/> b/tests/mcast-snooping.at <http://mcast-snooping.at/> > index c30667b..ad818a3 100644 > --- a/tests/mcast-snooping.at <http://mcast-snooping.at/> > +++ b/tests/mcast-snooping.at <http://mcast-snooping.at/> > @@ -181,6 +181,8 @@ AT_CHECK([ > -- set Interface p2 type=dummy other-config:hwaddr=aa:55:aa:55:00:02 ofport_request=2 \ > ], [0]) > > +ovs-appctl time/stop > + > # send report packets > AT_CHECK([ > ovs-appctl netdev-dummy/receive p1 \ > -- > 2.10.2.windows.1
On Wed, Mar 08, 2017 at 02:31:56PM +0000, Alin Serdean wrote: > On slow systems(or which start processes slow) the test: > `testing mcast - delete the port mdb when port destroyed` > is influenced by the running time. > i.e.: http://64.119.130.115/ovs/911b7e9b08b9f4f890eeecd228d5124f4ce94d4e/testsuite.dir/2326/testsuite.log.gz > > This patches adds a time stop on vswitchd. > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Applied, thanks.
diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at index c30667b..ad818a3 100644 --- a/tests/mcast-snooping.at +++ b/tests/mcast-snooping.at @@ -181,6 +181,8 @@ AT_CHECK([ -- set Interface p2 type=dummy other-config:hwaddr=aa:55:aa:55:00:02 ofport_request=2 \ ], [0]) +ovs-appctl time/stop + # send report packets AT_CHECK([ ovs-appctl netdev-dummy/receive p1 \
On slow systems(or which start processes slow) the test: `testing mcast - delete the port mdb when port destroyed` is influenced by the running time. i.e.: http://64.119.130.115/ovs/911b7e9b08b9f4f890eeecd228d5124f4ce94d4e/testsuite.dir/2326/testsuite.log.gz This patches adds a time stop on vswitchd. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> --- tests/mcast-snooping.at | 2 ++ 1 file changed, 2 insertions(+)