diff mbox

[ovs-dev] util: Remove obsolete comment.

Message ID 20170104172354.25358-1-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Jan. 4, 2017, 5:23 p.m. UTC
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 include/openvswitch/util.h | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Simon Horman Jan. 5, 2017, 8:17 a.m. UTC | #1
On Wed, Jan 04, 2017 at 09:23:54AM -0800, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff <blp@ovn.org>

Acked-by: Simon Horman <simon.horman@netronome.com>

> ---
>  include/openvswitch/util.h | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/include/openvswitch/util.h b/include/openvswitch/util.h
> index 06bd2d0..8453550 100644
> --- a/include/openvswitch/util.h
> +++ b/include/openvswitch/util.h
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2016 Nicira, Inc.
> + * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2016, 2017 Nicira, Inc.
>   *
>   * Licensed under the Apache License, Version 2.0 (the "License");
>   * you may not use this file except in compliance with the License.
> @@ -73,11 +73,7 @@ OVS_NO_RETURN void ovs_assert_failure(const char *, const char *, const char *);
>      ((void) sizeof ((int) ((POINTER) == (TYPE) (POINTER))))
>  
>  /* Casts 'pointer' to 'type' and issues a compiler warning if the cast changes
> - * anything other than an outermost "const" or "volatile" qualifier.
> - *
> - * The cast to int is present only to suppress an "expression using sizeof
> - * bool" warning from "sparse" (see
> - * http://permalink.gmane.org/gmane.comp.parsers.sparse/2967). */
> + * anything other than an outermost "const" or "volatile" qualifier. */
>  #define CONST_CAST(TYPE, POINTER)                               \
>      (BUILD_ASSERT_TYPE(POINTER, TYPE),                          \
>       (TYPE) (POINTER))
> -- 
> 2.10.2
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Ben Pfaff Jan. 5, 2017, 3:23 p.m. UTC | #2
On Thu, Jan 05, 2017 at 09:17:22AM +0100, Simon Horman wrote:
> On Wed, Jan 04, 2017 at 09:23:54AM -0800, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> 
> Acked-by: Simon Horman <simon.horman@netronome.com>

Thanks, applied.
diff mbox

Patch

diff --git a/include/openvswitch/util.h b/include/openvswitch/util.h
index 06bd2d0..8453550 100644
--- a/include/openvswitch/util.h
+++ b/include/openvswitch/util.h
@@ -1,5 +1,5 @@ 
 /*
- * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2016 Nicira, Inc.
+ * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2016, 2017 Nicira, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -73,11 +73,7 @@  OVS_NO_RETURN void ovs_assert_failure(const char *, const char *, const char *);
     ((void) sizeof ((int) ((POINTER) == (TYPE) (POINTER))))
 
 /* Casts 'pointer' to 'type' and issues a compiler warning if the cast changes
- * anything other than an outermost "const" or "volatile" qualifier.
- *
- * The cast to int is present only to suppress an "expression using sizeof
- * bool" warning from "sparse" (see
- * http://permalink.gmane.org/gmane.comp.parsers.sparse/2967). */
+ * anything other than an outermost "const" or "volatile" qualifier. */
 #define CONST_CAST(TYPE, POINTER)                               \
     (BUILD_ASSERT_TYPE(POINTER, TYPE),                          \
      (TYPE) (POINTER))