From patchwork Tue Dec 20 21:16:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 707579 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tjrDv4XDWz9t2T for ; Wed, 21 Dec 2016 08:16:14 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 9932AC2D; Tue, 20 Dec 2016 21:16:11 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C52E2C22 for ; Tue, 20 Dec 2016 21:16:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3CB5C182 for ; Tue, 20 Dec 2016 21:16:10 +0000 (UTC) Received: from mfilter30-d.gandi.net (mfilter30-d.gandi.net [217.70.178.161]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id 16D4CFB8B6; Tue, 20 Dec 2016 22:16:09 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter30-d.gandi.net Received: from relay6-d.mail.gandi.net ([IPv6:::ffff:217.70.183.198]) by mfilter30-d.gandi.net (mfilter30-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id Z1omGUask5ZZ; Tue, 20 Dec 2016 22:16:07 +0100 (CET) X-Originating-IP: 208.91.2.3 Received: from sigabrt.benpfaff.org (unknown [208.91.2.3]) (Authenticated sender: blp@ovn.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D52A9FB8A4; Tue, 20 Dec 2016 22:16:05 +0100 (CET) From: Ben Pfaff To: dev@openvswitch.org Date: Tue, 20 Dec 2016 13:16:03 -0800 Message-Id: <20161220211603.28510-1-blp@ovn.org> X-Mailer: git-send-email 2.10.2 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ben Pfaff Subject: [ovs-dev] [PATCH] tests: Regenerate atlocal when running tests. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org A previous patch fixed double rebuilds when running tests in some cases. That patch removed dependencies from targets in tests/automake.mk that were redundant because the "all" target already depended on them. A dependency on tests/atlocal was also removed in the belief that "all" depended on tests/atlocal. This belief was incorrect, which meant that tests/atlocal would not get regenerated if it was removed or out of date. This commit fixes the problem. Reported-by: Joe Stringer Fixes: a8cb456227b0 ("tests: Fix double-rebuild of testsuite for "check-valgrind" and similar.") Signed-off-by: Ben Pfaff Acked-by: Joe Stringer --- tests/automake.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/automake.mk b/tests/automake.mk index 4939d7c..f4d4879 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -112,6 +112,8 @@ SYSTEM_TESTSUITE_AT = \ tests/system-ovn.at \ tests/system-traffic.at +check_SCRIPTS += tests/atlocal + TESTSUITE = $(srcdir)/tests/testsuite TESTSUITE_PATCH = $(srcdir)/tests/testsuite.patch SYSTEM_KMOD_TESTSUITE = $(srcdir)/tests/system-kmod-testsuite