| Message ID | 20161111023926.23597-1-russell@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Nov 10, 2016 at 09:39:26PM -0500, Russell Bryant wrote: > ovn-trace will tell you when a packet processing ends because no flow is > matched in a given logical flow table. Update the output to clarify that > when this occurs, the packet is implicitly dropped. > > The output now looks like this: > > ingress(dp="sw0", inport="sw0-port1") > ------------------------------------- > 0. ls_in_port_sec_l2: no match (implicit drop) > > Signed-off-by: Russell Bryant <russell@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
On Fri, Nov 11, 2016 at 12:56 AM, Ben Pfaff <blp@ovn.org> wrote: > On Thu, Nov 10, 2016 at 09:39:26PM -0500, Russell Bryant wrote: > > ovn-trace will tell you when a packet processing ends because no flow is > > matched in a given logical flow table. Update the output to clarify that > > when this occurs, the packet is implicitly dropped. > > > > The output now looks like this: > > > > ingress(dp="sw0", inport="sw0-port1") > > ------------------------------------- > > 0. ls_in_port_sec_l2: no match (implicit drop) > > > > Signed-off-by: Russell Bryant <russell@ovn.org> > > Acked-by: Ben Pfaff <blp@ovn.org> > Thanks, applied to master.
diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index 692b274..13a980b 100644 --- a/ovn/utilities/ovn-trace.c +++ b/ovn/utilities/ovn-trace.c @@ -1359,7 +1359,7 @@ trace__(const struct ovntrace_datapath *dp, struct flow *uflow, ds_put_format(&s, "%s, priority %d", f->match_s, f->priority); } else { char *stage_name = ovntrace_stage_name(dp, table_id, pipeline); - ds_put_format(&s, "%s%sno match", + ds_put_format(&s, "%s%sno match (implicit drop)", stage_name ? stage_name : "", stage_name ? ": " : ""); free(stage_name);
ovn-trace will tell you when a packet processing ends because no flow is matched in a given logical flow table. Update the output to clarify that when this occurs, the packet is implicitly dropped. The output now looks like this: ingress(dp="sw0", inport="sw0-port1") ------------------------------------- 0. ls_in_port_sec_l2: no match (implicit drop) Signed-off-by: Russell Bryant <russell@ovn.org> --- ovn/utilities/ovn-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)